Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uriparser: 0.8.6 -> 0.9.0 #49306

Merged
merged 1 commit into from Oct 28, 2018
Merged

uriparser: 0.8.6 -> 0.9.0 #49306

merged 1 commit into from Oct 28, 2018

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Oct 27, 2018 •
edited

Motivation for this change

Solves: #49274

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Oct 27, 2018

@GrahamcOfBorg build uriparser

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: uriparser

Partial log (click to expand)

checking for wprintf... yes
checking for reallocarray... yes
checking for pkg-config... /nix/store/sbg7j9ghnhl3kiw5gck9khhr2wwd5y8f-pkg-config-0.29.2/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for GTEST... no
configure: error: Please install Googletest 1.8.1 or later.
                        Alternatively, you could pass --disable-test to the call to configure.
                        However, it is not recommended to disable the test suite.
builder for '/nix/store/r525fgipy2xryl2nb3yvfigqzyxw7vyz-uriparser-0.9.0.drv' failed with exit code 1
error: build of '/nix/store/r525fgipy2xryl2nb3yvfigqzyxw7vyz-uriparser-0.9.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: uriparser

Partial log (click to expand)

checking for wprintf... yes
checking for reallocarray... yes
checking for pkg-config... /nix/store/g8pbp9a8gk76wbx8wglkvpjzhj113mmg-pkg-config-0.29.2/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for GTEST... no
configure: error: Please install Googletest 1.8.1 or later.
                        Alternatively, you could pass --disable-test to the call to configure.
                        However, it is not recommended to disable the test suite.
builder for '/nix/store/bla57pvd0scpigryd2ik0ilpsdpja2x8-uriparser-0.9.0.drv' failed with exit code 1
error: build of '/nix/store/bla57pvd0scpigryd2ik0ilpsdpja2x8-uriparser-0.9.0.drv' failed

@dywedir
Copy link
Member

dywedir commented Oct 27, 2018

Looks like gtest is missing

Changed: Migrate test suite from CppTest to GoogleTest 1.8.1

@periklis
Copy link
Contributor Author

@dywedir Yes, i just catched that after skimming the changelog. But this PR depends on #49310

@jtojnar
Copy link
Contributor

jtojnar commented Oct 28, 2018

@GrahamcOfBorg build uriparser

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: uriparser

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: uriparser

Partial log (click to expand)

make[1]: Leaving directory '/build/uriparser-0.9.0/doc'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0
shrinking /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0/bin/uriparse
shrinking /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0/lib/liburiparser.so.1.0.23
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0/lib  /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0/bin
patching script interpreter paths in /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0
checking for references to /build in /nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0...
/nix/store/ssqysl0zz9ymccd3jj5ny2i4rimid994-uriparser-0.9.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: uriparser

Partial log (click to expand)

make[1]: Leaving directory '/build/uriparser-0.9.0/doc'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0
shrinking /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0/lib/liburiparser.so.1.0.23
shrinking /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0/bin/uriparse
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0/lib  /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0/bin
patching script interpreter paths in /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0
checking for references to /build in /nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0...
/nix/store/653f3zkxf8kj5bb9rpzi5bknsk7jxj4c-uriparser-0.9.0

@dywedir dywedir merged commit 0ab9e5c into NixOS:master Oct 28, 2018
@periklis periklis deleted the update-uriparser branch October 28, 2018 16:31
@periklis periklis mentioned this pull request Nov 1, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@periklis @dywedir @GrahamcOfBorg @jtojnar @roberth