Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt: minor refactor #49329

Merged
merged 1 commit into from Oct 28, 2018
Merged

fmt: minor refactor #49329

merged 1 commit into from Oct 28, 2018

Conversation

sephalon
Copy link
Contributor

Add separate build outputs, enable parallel building, fix platforms,
adapt to styleguide.

Motivation for this change

I've packaged this library at the same instant of time by coincidence…

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

oxzi
oxzi reviewed Oct 28, 2018
View reviewed changes
pkgs/development/libraries/fmt/default.nix Outdated

outputs = [ "out" "dev" ];

buildInputs = [ cmake ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you moved cmake from nativeBuildInputs to buildInputs?
Shouldn't cmake be a build time only dependency?

Suggested change
buildInputs = [ cmake ];
nativeBuildInputs = [ cmake ];

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed. cmake belongs in nativeBuildInputs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups, that move was a mistake. Fixed.

@sephalon
fmt: minor refactor
b23d92f 
Add separate build outputs, enable parallel building, fix platforms,
adapt to styleguide.
@Mic92
Copy link
Member

Mic92 commented Oct 28, 2018

@GrahamcOfBorg build fmt

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: fmt

Partial log (click to expand)

post-installation fixup
Moving /nix/store/ayfp18i1fhbls9xqkxjg47hvmja3l4ns-fmt-5.2.1/lib/cmake to /nix/store/gyqv8jbd7s69wwqq9q5c83nhrc4dhl2c-fmt-5.2.1-dev/lib/cmake
rmdir: failed to remove '/nix/store/ayfp18i1fhbls9xqkxjg47hvmja3l4ns-fmt-5.2.1/lib': Directory not empty
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ayfp18i1fhbls9xqkxjg47hvmja3l4ns-fmt-5.2.1/lib
patching script interpreter paths in /nix/store/ayfp18i1fhbls9xqkxjg47hvmja3l4ns-fmt-5.2.1
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gyqv8jbd7s69wwqq9q5c83nhrc4dhl2c-fmt-5.2.1-dev/lib
patching script interpreter paths in /nix/store/gyqv8jbd7s69wwqq9q5c83nhrc4dhl2c-fmt-5.2.1-dev
/nix/store/ayfp18i1fhbls9xqkxjg47hvmja3l4ns-fmt-5.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fmt

Partial log (click to expand)

strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y37qw5m18isgc9rb08lshxiph4jmmv2f-fmt-5.2.1/lib
patching script interpreter paths in /nix/store/y37qw5m18isgc9rb08lshxiph4jmmv2f-fmt-5.2.1
checking for references to /build in /nix/store/y37qw5m18isgc9rb08lshxiph4jmmv2f-fmt-5.2.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/idxrcm2d9c625madh5bd1v68xijgkk1p-fmt-5.2.1-dev
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/idxrcm2d9c625madh5bd1v68xijgkk1p-fmt-5.2.1-dev/lib
patching script interpreter paths in /nix/store/idxrcm2d9c625madh5bd1v68xijgkk1p-fmt-5.2.1-dev
checking for references to /build in /nix/store/idxrcm2d9c625madh5bd1v68xijgkk1p-fmt-5.2.1-dev...
/nix/store/y37qw5m18isgc9rb08lshxiph4jmmv2f-fmt-5.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fmt

Partial log (click to expand)

strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ss6cfy0cd8zfxi17x8nxzcx78n2kqjdk-fmt-5.2.1/lib
patching script interpreter paths in /nix/store/ss6cfy0cd8zfxi17x8nxzcx78n2kqjdk-fmt-5.2.1
checking for references to /build in /nix/store/ss6cfy0cd8zfxi17x8nxzcx78n2kqjdk-fmt-5.2.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/cz6gnpg2b0jy4bag2rz6cdkfrwm9v5nk-fmt-5.2.1-dev
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cz6gnpg2b0jy4bag2rz6cdkfrwm9v5nk-fmt-5.2.1-dev/lib
patching script interpreter paths in /nix/store/cz6gnpg2b0jy4bag2rz6cdkfrwm9v5nk-fmt-5.2.1-dev
checking for references to /build in /nix/store/cz6gnpg2b0jy4bag2rz6cdkfrwm9v5nk-fmt-5.2.1-dev...
/nix/store/ss6cfy0cd8zfxi17x8nxzcx78n2kqjdk-fmt-5.2.1

@Mic92 Mic92 merged commit 426d35d into NixOS:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxzi oxzi oxzi left review comments

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sephalon @Mic92 @GrahamcOfBorg @oxzi @c0bw3b