Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mdadm: 4.0 -> 4.1 #49332

Merged
merged 1 commit into from Oct 28, 2018
Merged

mdadm: 4.0 -> 4.1 #49332

merged 1 commit into from Oct 28, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Oct 28, 2018

Motivation for this change

Bumping mdadm. I've also added myself as a maintainer, given no one was listed there yet and this update is already almost a month old.

The changelog mentions a lot of “enhancements and bug fixes”, so I'm not sure whether this should be backported: there is apparently no security fix, but it's a well-known part of the fundamental ecosystem which made a minor release. And a bug fix in mdadm can have big consequences… just as much as a bug introduced in mdadm. For the comparison, debian testing is at 4.1rc1, debian stable is at 3.4.4, fedora 29 is at 4.1rc2 (a bit older than the last version at their freeze), fedora 28 is at 4.0.

So overall I'd likely say not to backport, but without strong sentiments.

Things done

Tested by building the package and verifying that the mdadm and mdmon executables can actually run.

Tried to test with nixos/tests/installer.nix, but it OOM's both without and with this patch applied here…
@GrahamcOfBorg test installer

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mdadm

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1
shrinking /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/sbin/mdmon
shrinking /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/sbin/mdadm
gzipping man pages under /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/lib  /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/sbin
patching script interpreter paths in /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1
checking for references to /build in /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1...
moving /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/sbin/* to /nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1/bin
/nix/store/45shkk7yicb4cskxk3lvmk045b6i21qr-mdadm-4.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mdadm

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1
shrinking /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/sbin/mdmon
shrinking /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/sbin/mdadm
gzipping man pages under /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/lib  /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/sbin
patching script interpreter paths in /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1
checking for references to /build in /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1...
moving /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/sbin/* to /nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1/bin
/nix/store/hxkw03hfkawy9i6dhp4zl47sybdykwqc-mdadm-4.1

@Ekleog
Copy link
Member Author

Ekleog commented Oct 28, 2018

Let's try again the installer test

@GrahamcOfBorg test installer

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.installer

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.installer

No partial log is available.

@markuskowa
Copy link
Member

The installer test fail is due to too small GC heap in the VMs (https://github.com/NixOS/nixpkgs/pull/49328/files fixes that).

@markuskowa
Copy link
Member

I can build the test swraid in nixos/tests/installer.nix locally. I would not recommend a backport if there's no problem.

@markuskowa markuskowa merged commit bf939f7 into NixOS:master Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @markuskowa