Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchexec: fix darwin build #49284

Merged
merged 1 commit into from Nov 8, 2018
Merged

watchexec: fix darwin build #49284

merged 1 commit into from Nov 8, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 27, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: watchexec

Partial log (click to expand)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

installing
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ckvmilhbjjf91s98n249vqspnnffyxxh-watchexec-1.9.0/bin
patching script interpreter paths in /nix/store/ckvmilhbjjf91s98n249vqspnnffyxxh-watchexec-1.9.0
/nix/store/ckvmilhbjjf91s98n249vqspnnffyxxh-watchexec-1.9.0

matthewbauer
matthewbauer reviewed Oct 27, 2018
View reviewed changes
pkgs/tools/misc/watchexec/default.nix
buildInputs = stdenv.lib.optionals stdenv.isDarwin [ CoreServices ];

# FIXME: Use impure version of CoreFoundation because of missing symbols.
# Undefined symbols for architecture x86_64: "_CFURLResourceIsReachable"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copumpkin seemed to think this was fixed in:

https://bugs.swift.org/plugins/servlet/mobile#issue/SR-3178

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was kind of expecting this to work now that we're using that.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: watchexec

Partial log (click to expand)

make[3]: Entering directory '/build/rustc-1.30.0-src/build/x86_64-unknown-linux-gnu/llvm/build'
[ 63%] Building CXX object lib/Target/ARM/AsmParser/CMakeFiles/LLVMARMAsmParser.dir/ARMAsmParser.cpp.o
[ 63%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMBaseRegisterInfo.cpp.o
[ 63%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMCallLowering.cpp.o
[ 63%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMCodeGenPrepare.cpp.o
[ 64%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/ARMConstantIslandPass.cpp.o
building of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/amvxhnkmn7szrbgp5k6zrd9nrms8i7cj-cargo-1.30.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r3nliiq3kh42vcxxv9jf0b3ccnb71d72-watchexec-1.9.0.drv': 2 dependencies couldn't be built
error: build of '/nix/store/r3nliiq3kh42vcxxv9jf0b3ccnb71d72-watchexec-1.9.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: watchexec

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vp1inb1iicqnl8ddw84izwripmm070fr-watchexec-1.9.0
shrinking /nix/store/vp1inb1iicqnl8ddw84izwripmm070fr-watchexec-1.9.0/bin/watchexec
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vp1inb1iicqnl8ddw84izwripmm070fr-watchexec-1.9.0/bin
patching script interpreter paths in /nix/store/vp1inb1iicqnl8ddw84izwripmm070fr-watchexec-1.9.0
checking for references to /build in /nix/store/vp1inb1iicqnl8ddw84izwripmm070fr-watchexec-1.9.0...
/nix/store/vp1inb1iicqnl8ddw84izwripmm070fr-watchexec-1.9.0

@LnL7 LnL7 merged commit a06e7c5 into NixOS:master Nov 8, 2018
@LnL7 LnL7 deleted the darwin-watchexec branch November 8, 2018 19:04
@dywedir dywedir mentioned this pull request May 29, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @matthewbauer