Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electrum: fix sha256 for 3.2.3 #49322

Merged
merged 1 commit into from Oct 28, 2018
Merged

electrum: fix sha256 for 3.2.3 #49322

merged 1 commit into from Oct 28, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Oct 28, 2018

Motivation for this change

The source hash did not match when I tried to build Electrum 3.2.3.

I have checked pkgs.electrum.src against the GPG signature from https://download.electrum.org/3.2.3/Electrum-3.2.3.tar.gz.asc

/cc @joachifm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@rvl
electrum: fix sha256 for 3.2.3
fa0b193 
I have checked pkgs.electrum.src against the GPG signature from
https://download.electrum.org/3.2.3/Electrum-3.2.3.tar.gz.asc
@joachifm
Copy link
Contributor

joachifm commented Oct 28, 2018 •
edited

The discrepancy appears to be due to upstream replacing the tarball with a new one that adds bundled dependencies (compared to the tarball from the nixos.org cache).

@joachifm
Copy link
Contributor

@GrahamcOfBorg build electrum

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: electrum

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: electrum

Partial log (click to expand)

[ 63%] Building CXX object lib/Target/ARM/CMakeFiles/LLVMARMCodeGen.dir/A15SDOptimizer.cpp.o
[ 63%] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstrFoldTables.cpp.o
[ 63%] Building CXX object lib/Target/X86/CMakeFiles/LLVMX86CodeGen.dir/X86InstrInfo.cpp.o
building of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' timed out after 1800 seconds
cannot build derivation '/nix/store/amvxhnkmn7szrbgp5k6zrd9nrms8i7cj-cargo-1.30.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/s45nfy009nwq82bh7k6440z6q1ga7d82-librsvg-2.42.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/37cpvjdlbdyqrakhpjkbdyyl33d7jy67-imagemagick-6.9.9-34.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4j9x4ixdn8881shgzvas7zl342z76bhy-zbar-0.10.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/0d5ksc31h6x8pqxwrjcr5vq12fq8nsg4-electrum-3.2.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/0d5ksc31h6x8pqxwrjcr5vq12fq8nsg4-electrum-3.2.3.drv' failed

@rvl
Copy link
Contributor Author

rvl commented Oct 28, 2018

Ah ok that explains it, thanks.

@joachifm joachifm merged commit b4b95a3 into NixOS:master Oct 28, 2018
@rvl rvl deleted the electrum-3.2.3 branch October 28, 2018 07:54
@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: electrum

Partial log (click to expand)

     if (index < 0 || index >= m_items.size())
                      ~~~~~~^~~~~~~~~~~~~~~~~
/build/source/Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp: In member function 'void WebKit::PopupMenuItemModel::buildItems(const WTF::Vector<WebKit::WebPopupItem>&)':
/build/source/Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:253:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (int i = 0; i < webPopupItems.size(); i++) {
                     ~~^~~~~~~~~~~~~~~~~~~~~~
building of '/nix/store/kdy6qprh2c2jdmallx9gw8yi94dwpqyf-qtwebkit-5.212-alpha-01-26-2018.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/j440b3xr5nqghrkv008cl9i0cnnfhb4y-python3.6-PyQt-5.10.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6bzf1r3xarslfvac8jik5fx1wpvw6jiv-electrum-3.2.3.drv': 2 dependencies couldn't be built
error: build of '/nix/store/6bzf1r3xarslfvac8jik5fx1wpvw6jiv-electrum-3.2.3.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvl @joachifm @GrahamcOfBorg