Remove old OCaml versions. #48053
Merged
Remove old OCaml versions. #48053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be also interesting how many 4.0x versions we need. But I have not enough inside knowledge to decide that. |
|
@Mic92 I thought about going further and removing everything before 4.02 but I figured I would have more difficulties and I'd wait for feedback here before doing so. |
|
Please also remove matita. It has been broken for decades. |
|
OK |
This requires removing also the Coq 8.3 and Matita 0.5.8 packages. Coq 8.3 was released 8 years ago (2010) and there is no trace left of users of this version (contrary to Coq 8.4, released 2012). It is well over time to remove it. Matita 0.5.8 was released in 2010 and because this version was still used for teaching according to the official website, a legacy release (0.5.9) was released in 5 years later to compile with more recent OCaml libraries. Updating to 0.5.9 (or a more recent version like 0.99.3) should allow getting rid of the dependency on older OCaml but it is hard to test given that the package is already broken before this update.
Zimmi48
force-pushed
the
clean-up/ocaml
branch
from
8807a31
to
70eb6bf
Compare
|
The last commit was done quickly and is untested. |
|
There is an evaluation error still there according to ofBorg. |
As requested by Vincent Laporte.
Zimmi48
force-pushed
the
clean-up/ocaml
branch
from
70eb6bf
to
c76ffb9
Compare
|
Seems to have passed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
OCaml is currently shipped in more than 10 versions on nixpkgs (which is quite original compared to the general policy in nixpkgs of maintaining very few versions). In particular, there are 4 version pre-OCaml 4 and only one broken package (Matita) and one very old version of Coq (8.3) depend on them. It seems like it is time for this clean-up.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Note that I am not sure if
nox-review wipis enough to properly test this. I might have missed some stuff.