Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

konqueror: init at 18.08 #48033

Merged
merged 1 commit into from Nov 1, 2018
Merged

konqueror: init at 18.08 #48033

merged 1 commit into from Nov 1, 2018

Conversation

colemickens
Copy link
Member

Motivation for this change

It looks like konqueror isn't packaged?

NOTE: I need some help testing this. It doesn't seem to always have the correct DPI, and is missing icons, but that may just be because of other local changes or my DE/WM setup at the moment. (I'm changing things up and not sure Qt apps are working correctly right now).

So if someone else can test and let me know, that would be helpful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [sorta] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nyanloutre
Copy link
Member

nyanloutre commented Oct 8, 2018

Seems to be packaged here:

konqueror = {

Edit: never mind, I was wrong :)

@colemickens
Copy link
Member Author

My issues were related to QT5 running under Sway.

This package seems to work fine. Can someone take a look? Thanks.

@colemickens colemickens changed the title WIP: konqueror: init at 18.08 konqueror: init at 18.08 Oct 25, 2018
@7c6f434c 7c6f434c merged commit 650fd5b into NixOS:master Nov 1, 2018
@colemickens colemickens deleted the konqueror branch November 2, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants