Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.mutter: fix crash on startup with nvidia drivers #48047

Merged
merged 1 commit into from Nov 4, 2018
Merged

gnome3.mutter: fix crash on startup with nvidia drivers #48047

merged 1 commit into from Nov 4, 2018

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Oct 8, 2018 •
edited

Motivation for this change

Tracking down why my desktop is crashing after upgrade to 18.09. I don't know if this is the actual cause, but it's a fix that applies to the current version of mutter (3.28.3), and is currently absent from the gnome3.mutter package.

While we're here, are there any other patches that were backported by Ubuntu that are important? https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/1767956/comments/8

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Oct 8, 2018
@thefloweringash
Copy link
Member Author

Ok, I'm definitely hitting this:

Thread 1 (Thread 0x7ff8edadac00 (LWP 5963)):
#0  0x00007ff8eb15911d in meta_gpu_kms_new () from /nix/store/30qdys8akxm9ka1ayd9ws26kn7radjqk-mutter-3.28.3/lib/libmutter-2.so.0
#1  0x00007ff8eb15a9ba in meta_monitor_manager_kms_initable_init ()
   from /nix/store/30qdys8akxm9ka1ayd9ws26kn7radjqk-mutter-3.28.3/lib/libmutter-2.so.0
#2  0x00007ff8ed17c367 in g_initable_new_valist () from /nix/store/wgki8qb0h5q963pm890i0i3kpf15mmd8-glib-2.56.0/lib/libgio-2.0.so.0
#3  0x00007ff8ed17c419 in g_initable_new () from /nix/store/wgki8qb0h5q963pm890i0i3kpf15mmd8-glib-2.56.0/lib/libgio-2.0.so.0
#4  0x00007ff8eb0b9e91 in meta_backend_initable_init () from /nix/store/30qdys8akxm9ka1ayd9ws26kn7radjqk-mutter-3.28.3/lib/libmutter-2.so.0
#5  0x00007ff8eb0ba8b4 in meta_init_backend () from /nix/store/30qdys8akxm9ka1ayd9ws26kn7radjqk-mutter-3.28.3/lib/libmutter-2.so.0
#6  0x00007ff8eb101d3f in meta_init () from /nix/store/30qdys8akxm9ka1ayd9ws26kn7radjqk-mutter-3.28.3/lib/libmutter-2.so.0
#7  0x0000000000402d5a in main ()

@thefloweringash
Copy link
Member Author

This is a fairly small change that prevents a crash, directly from the upstream, already included in Ubuntu. I think it might have fallen through the cracks. cc @jtojnar @lethalman as maintainers.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 4, 2018

@GrahamcOfBorg build gnome3.mutter

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gnome3.mutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnome3.mutter

Partial log (click to expand)

shrinking /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/lib/mutter/libmutter-cogl-path-2.so
shrinking /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/lib/libmutter-2.so.0.0.0
shrinking /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/libexec/mutter-restart-helper
shrinking /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/bin/.mutter-wrapped
gzipping man pages under /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/lib  /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/libexec  /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3/bin
patching script interpreter paths in /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3
checking for references to /build in /nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3...
/nix/store/z5z2n1v0z1dy16mw7fzmfxzh48vd454n-mutter-3.28.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnome3.mutter

Partial log (click to expand)

shrinking /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/lib/mutter/libmutter-clutter-2.so
shrinking /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/lib/mutter/libmutter-cogl-pango-2.so
shrinking /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/lib/mutter/libmutter-cogl-path-2.so
shrinking /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/lib/mutter/libmutter-cogl-2.so
gzipping man pages under /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/lib  /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/libexec  /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3/bin
patching script interpreter paths in /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3
checking for references to /build in /nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3...
/nix/store/nv4lyg85if91j68hdmsdjzglawybbpd2-mutter-3.28.3

@jtojnar jtojnar merged commit 033dce3 into NixOS:master Nov 4, 2018
@thefloweringash
Copy link
Member Author

Thank you! Can we backport to 18.09 trivially, or should I open another PR for that?

@jtojnar
Copy link
Contributor

jtojnar commented Nov 4, 2018

Please open a PR. Do not forget to use git cherry-pick -x

@thefloweringash thefloweringash mentioned this pull request Nov 4, 2018
Merged
9 tasks
@thefloweringash thefloweringash deleted the fix-mutter-crash branch November 4, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thefloweringash @jtojnar @GrahamcOfBorg