Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudflare-cli: init v3.2.0 #48030

Closed
wants to merge 1 commit into from
Closed

cloudflare-cli: init v3.2.0 #48030

wants to merge 1 commit into from

Conversation

colemickens
Copy link
Member

Motivation for this change

Add cfcli (cloudflare-cli)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

c0bw3b
c0bw3b reviewed Oct 8, 2018
View reviewed changes
pkgs/development/node-packages/node-packages-v10.nix
@@ -1872,7 +1872,7 @@ let
packageName = "strip-ansi";
version = "3.0.1";
src = fetchurl {
url = "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";
url = "http://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not versed in Node packaging but this feels unnecessary.

c0bw3b
c0bw3b reviewed Oct 8, 2018
View reviewed changes
pkgs/development/node-packages/node-packages-v6.nix
@@ -1872,7 +1872,7 @@ let
packageName = "strip-ansi";
version = "3.0.1";
src = fetchurl {
url = "https://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";
url = "http://registry.npmjs.org/strip-ansi/-/strip-ansi-3.0.1.tgz";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@colemickens
Copy link
Member Author

Thank you for the review @c0bw3b. I tend not to edit things that have been auto-generated (in this case, the *.nix are generated with generate.sh in the same directory.

But, obviously I don't think the cases you've found are good changes.

@svanderburg Can you weigh in on this? Is there a reason that these would be getting switched to http rather than https? Should I manually undo those changes and leave them as HTTPS? Is there an upstream issue for node2nix that covers this case?

Thanks all.

@colemickens colemickens mentioned this pull request Oct 13, 2018
Closed
colemickens
colemickens commented Oct 13, 2018
View reviewed changes
pkgs/development/node-packages/node-packages-v8.nix
@@ -4392,7 +4401,7 @@ let
packageName = "bl";
version = "0.8.2";
src = fetchurl {
url = "https://registry.npmjs.org/bl/-/bl-0.8.2.tgz";
url = "http://registry.npmjs.org/bl/-/bl-0.8.2.tgz";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

pkgs/development/node-packages/node-packages-v8.nix
@@ -4401,7 +4410,7 @@ let
packageName = "bl";
version = "1.0.3";
src = fetchurl {
url = "https://registry.npmjs.org/bl/-/bl-1.0.3.tgz";
url = "http://registry.npmjs.org/bl/-/bl-1.0.3.tgz";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here... (and a number after this too.)

@colemickens
Copy link
Member Author

NOTE to self: per this NixCon talk (https://youtu.be/vv4d42vbICw?t=41m7s) consider using pnpm2nix: https://github.com/adisbladis/pnpm2nix

@colemickens
Copy link
Member Author

I don't use this, don't want to maintain it, it doesn't merge, etc. Closing...

@colemickens colemickens closed this Dec 9, 2019
@colemickens colemickens deleted the cloudflare-cli branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colemickens @c0bw3b @ryantm @GrahamcOfBorg