Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinc: 1.0.34 -> 1.0.35, 1.1pre16 -> 1.1pre17 (security update) #48050

Merged
merged 1 commit into from Oct 8, 2018
Merged

tinc: 1.0.34 -> 1.0.35, 1.1pre16 -> 1.1pre17 (security update) #48050

merged 1 commit into from Oct 8, 2018

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 8, 2018 •
edited

Motivation for this change

Critical security update (CVE-2018-16737, CVE-2018-16738, CVE-2018-16758).
Should be backported to release-18.03 and release-18.09 as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pacien pacien changed the title tinc: 1.0.34 -> 1.0.35, 1.1pre16 -> 1.1pre17 tinc: 1.0.34 -> 1.0.35, 1.1pre16 -> 1.1pre17 (security update) Oct 8, 2018
@andir
Copy link
Member

andir commented Oct 8, 2018 •
edited

Announcement is here: https://www.tinc-vpn.org/pipermail/tinc/2018-October/005311.html

@andir
Copy link
Member

andir commented Oct 8, 2018

Verified the build locally. Lets see if ofborg is also happy :)

@GrahamcOfBorg build tinc tinc_pre

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tinc, tinc_pre

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/rnhf9i5m351mbl6zanpf4ysxqi5q9f35-tinc-1.1pre17/sbin
patching script interpreter paths in /nix/store/rnhf9i5m351mbl6zanpf4ysxqi5q9f35-tinc-1.1pre17
moving /nix/store/rnhf9i5m351mbl6zanpf4ysxqi5q9f35-tinc-1.1pre17/sbin/* to /nix/store/rnhf9i5m351mbl6zanpf4ysxqi5q9f35-tinc-1.1pre17/bin
gzipping man pages under /nix/store/wva383q83r030b6nfwyha1q75f83pn0c-tinc-1.1pre17-man/share/man/
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/wva383q83r030b6nfwyha1q75f83pn0c-tinc-1.1pre17-man
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/vyg73ajc72g9lqb95zli222gg4qzzfjy-tinc-1.1pre17-info
/nix/store/7k94r0xamv6mfbs3ahsprqxwh5hbz9b1-tinc-1.0.35
/nix/store/rnhf9i5m351mbl6zanpf4ysxqi5q9f35-tinc-1.1pre17

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tinc, tinc_pre

Partial log (click to expand)

gzipping man pages under /nix/store/snyjhdr1w8ydgjm0yg0ndqsvv0f38qxr-tinc-1.1pre17-man/share/man/
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/snyjhdr1w8ydgjm0yg0ndqsvv0f38qxr-tinc-1.1pre17-man
checking for references to /build in /nix/store/snyjhdr1w8ydgjm0yg0ndqsvv0f38qxr-tinc-1.1pre17-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/rsrlmd5ry0dzz4wbz1bpd9pswhah5f6x-tinc-1.1pre17-info
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/rsrlmd5ry0dzz4wbz1bpd9pswhah5f6x-tinc-1.1pre17-info
checking for references to /build in /nix/store/rsrlmd5ry0dzz4wbz1bpd9pswhah5f6x-tinc-1.1pre17-info...
/nix/store/m1x0qfazpddd21g3qdvgsbc60ass8bhr-tinc-1.0.35
/nix/store/6dd787lzl32n9vp6pkam8hb7pnl6h0fp-tinc-1.1pre17

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tinc, tinc_pre

Partial log (click to expand)

gzipping man pages under /nix/store/lk513wl25851f8f1cyf3rp7x6yh0gpa5-tinc-1.1pre17-man/share/man/
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lk513wl25851f8f1cyf3rp7x6yh0gpa5-tinc-1.1pre17-man
checking for references to /build in /nix/store/lk513wl25851f8f1cyf3rp7x6yh0gpa5-tinc-1.1pre17-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/0q1ff0z6c8pgb3mvvzd8yk8xmsp97p50-tinc-1.1pre17-info
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/0q1ff0z6c8pgb3mvvzd8yk8xmsp97p50-tinc-1.1pre17-info
checking for references to /build in /nix/store/0q1ff0z6c8pgb3mvvzd8yk8xmsp97p50-tinc-1.1pre17-info...
/nix/store/fpiagibzs8pfi4snjvqn0h9fyyw3a1cc-tinc-1.0.35
/nix/store/7k0brbbzz5bg1z15fg07n8ikh7m43j6v-tinc-1.1pre17

@andir andir merged commit cefd0f7 into NixOS:master Oct 8, 2018
@andir
Copy link
Member

andir commented Oct 8, 2018

Thank you @pacien 👍

@andir
Copy link
Member

andir commented Oct 8, 2018

Backported in 859a4d3 & 21293d2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacien @andir @GrahamcOfBorg