Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nextcloud: extend documentation on nginx #48041

Merged
merged 1 commit into from Oct 22, 2018

Conversation

Vskilet
Copy link
Contributor

@Vskilet Vskilet commented Oct 8, 2018

Motivation for this change

I suggested #47868 but finally extend doc is a better solution.

Sorry to re-pull but I had a problem with my repo so I restarted from the beginning.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

description = ''
Enable nginx vhost management.
Further nginx configuration can be done by adapting <literal>nginx.virtualHosts.&lt;name&gt;</literal>.
See <link xlink:href="https://nixos.org/nixos/options.html#nginx.virtualhosts.%3Cname%3E"/> for further information.
Copy link
Member

@Mic92 Mic92 Oct 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc do you know how one can link to local manual options instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be achieved with <xref linked="<id-of-chapter-to-link>" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be achieved with <xref linked="<id-of-chapter-to-link>" />

How can I find the ID of chapter ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found and correct on #48041

@fpletz fpletz changed the title nixos/nextcloud : extend documentation on nginx nixos/nextcloud: extend documentation on nginx Oct 11, 2018
Co-authored-by: Robin Gloster <mail@glob.in>
@globin globin merged commit 2a164f5 into NixOS:master Oct 22, 2018
@Vskilet Vskilet deleted the nextcloud-improuvements branch May 1, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants