Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Use fetchFromGitHub instead of fetchurl #48044

Merged
merged 16 commits into from Nov 14, 2018
Merged

treewide: Use fetchFromGitHub instead of fetchurl #48044

merged 16 commits into from Nov 14, 2018

Conversation

schneefux
Copy link
Contributor

Motivation for this change

As per #32997, replaced a few calls of fetchurl by fetchFromGitHub.
Replaced fetchgit by fetchFromGitHub where, according to the comments, submodule support was needed but not present. See also #27327 (comment) for a discussion whether to prefer fetchgit for GitHub.
Also updated the affected packages sutils, bootchart, moonlight-embedded, neopg and nitrokey-app to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@schneefux
reptyr: use fetchFromGitHub instead of fetchurl
a6dd310
@schneefux
sutils: use fetchFromGitHub instead of fetchurl
caff6f5
@schneefux
sutils: 0.1 -> 0.2
aa5fd37
@schneefux
pingtcp: use fetchFromGitHub instead of fetchgit
b7d587f
@schneefux
i3minator: use fetchFromGitHub instead of fetchurl
fc1aaf8
@schneefux
moonlight-embedded: use fetchFromGitHub instead of fetchgit
8d4c3a0
@schneefux
shadowsocks-libev: use fetchFromGitHub instead of fetchgit
027ee44
@schneefux
bootchart: use fetchFromGitHub instead of fetchurl
1952a19
@schneefux
bootchart: 0.14.7 -> 0.14.8
3d5939f
@schneefux
moonlight-embedded: 2.4.6 -> 2.4.7
953f495
@schneefux
neopg: use fetchFromGitHub instead of fetchgit
15e23e5
@schneefux
nitrokey-app: use fetchFromGitHub instead of fetchgit
eb5eacb
@schneefux
neopg: 0.0.4 -> 0.0.5
0317371
@schneefux
nitrokey-app: 1.3.1 -> 1.3.2
3831ed4
@schneefux
tdesktop: use fetchFromGitHub instead of fetchgit
3145939
@schneefux
mirtk: use fetchFromGitHub instead of fetchgit
d81a96e
@Mic92 Mic92 changed the title Use fetchFromGitHub instead of fetchurl treewid: Use fetchFromGitHub instead of fetchurl Oct 8, 2018
@Mic92 Mic92 changed the title treewid: Use fetchFromGitHub instead of fetchurl treewide: Use fetchFromGitHub instead of fetchurl Oct 8, 2018
@schneefux
Copy link
Contributor Author

I can split this pull request if that makes the review easier.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 14, 2018

@GrahamcOfBorg build pingtcp shadowsocks-libev

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pingtcp, shadowsocks-libev

Partial log (click to expand)

shrinking /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0/bin/ss-manager
shrinking /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0/bin/ss-local
shrinking /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0/bin/ss-server
gzipping man pages under /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0/lib  /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0/bin
patching script interpreter paths in /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0
checking for references to /build in /nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0...
/nix/store/98biy5xqfms4dlp2jq9j4i455rhj5mfg-pingtcp-0.0.3
/nix/store/q122zzqfwfd86rydwkfjl37dlck3xlbx-shadowsocks-libev-3.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pingtcp, shadowsocks-libev

Partial log (click to expand)

shrinking /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0/bin/ss-local
shrinking /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0/bin/ss-server
shrinking /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0/bin/ss-manager
gzipping man pages under /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0/lib  /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0/bin
patching script interpreter paths in /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0
checking for references to /build in /nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0...
/nix/store/ridyb7zgvgs9xijhw7rfbkpc2j8anmhp-pingtcp-0.0.3
/nix/store/nj33x9rh861y0pl4x5grcd9yawmr30lx-shadowsocks-libev-3.2.0

@c0bw3b c0bw3b merged commit cde945a into NixOS:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@Synthetica9 Synthetica9 Synthetica9 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schneefux @c0bw3b @GrahamcOfBorg @Synthetica9