Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapidcheck: init at unstable-2018-09-27 #48048

Merged
merged 1 commit into from Oct 8, 2018
Merged

Conversation

jb55
Copy link
Contributor

@jb55 jb55 commented Oct 8, 2018

rapidcheck is a C++ property-based testing framework inspired by QuickCheck

Signed-off-by: William Casarin jb55@jb55.com

Motivation for this change

Needed it for testing property based tests recently added to Bitcoin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927/include/rapidcheck/Assertions.h
-- Installing: /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927/include/rapidcheck.h
-- Installing: /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927/lib
patching script interpreter paths in /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927
checking for references to /build in /nix/store/cbs7747i8qqks59yf893vkjiy08v5m8v-rapidcheck-git-20180927...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927/include/rapidcheck/state.h
-- Installing: /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927/include/rapidcheck/Traits.h
-- Installing: /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927/include/rapidcheck.h
-- Installing: /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927/lib
patching script interpreter paths in /nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927
/nix/store/y3gvrbizg46fx9m17039l3i30r8xpwnw-rapidcheck-git-20180927

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927/include/rapidcheck/fn/Common.hpp
-- Installing: /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927/include/rapidcheck.h
-- Installing: /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927/lib
patching script interpreter paths in /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927
checking for references to /build in /nix/store/jwz2xf01k1nr6vryxs8mpnn7kcvvgm5a-rapidcheck-git-20180927...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927/include/rapidcheck/Assertions.h
-- Installing: /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927/include/rapidcheck.h
-- Installing: /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927/lib
patching script interpreter paths in /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927
checking for references to /build in /nix/store/rgmdmxn3x70qz9zg9y26q3qp7i554qbh-rapidcheck-git-20180927...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927/include/rapidcheck/state.h
-- Installing: /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927/include/rapidcheck/Traits.h
-- Installing: /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927/include/rapidcheck.h
-- Installing: /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927/lib
patching script interpreter paths in /nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927
/nix/store/62cdpiwf27ajzmbwmxsa15v50cv7amm4-rapidcheck-git-20180927

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927/include/rapidcheck/Assertions.h
-- Installing: /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927/include/rapidcheck.h
-- Installing: /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927/lib
patching script interpreter paths in /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927
checking for references to /build in /nix/store/25czz6cbmf8s9kjsa6saankxa9gks2i2-rapidcheck-git-20180927...

sha256 = "0n8l0mlq9xqmpkgcj5xicicd1my2cfwxg25zdy8347dqkl1ppgbs";
};

buildInputs = [ cmake ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake should be in nativeBuildInputs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if tips like this could be automated �

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened a borg issue here NixOS/ofborg#245


stdenv.mkDerivation rec{
name = "rapidcheck-${version}";
version = "git-20180927";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On package naming the manual would rather suggest rapidcheck-unstable-2018-09-27

rapidcheck is a C++ property-based testing framework inspired by QuickCheck

Signed-off-by: William Casarin <jb55@jb55.com>
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27/include/rapidcheck/Seq.h
-- Installing: /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27/include/rapidcheck/Shrinkable.h
-- Installing: /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27
strip is /nix/store/dxf1m7dhc4qb655bdljc1fsd74v1nag3-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27/lib
patching script interpreter paths in /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27
checking for references to /build in /nix/store/j6k6j99nzbfpj6p3xgxw61crbxkx4hnj-rapidcheck-unstable-2018-09-27...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27/include/rapidcheck/Assertions.h
-- Installing: /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27/include/rapidcheck.h
-- Installing: /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27
strip is /nix/store/428gs2z4b8f9byvghzlpbjwjb3a7jwxx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27/lib
patching script interpreter paths in /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27
checking for references to /build in /nix/store/f62zacj94hchiyyxhkqdm52p49hq5qav-rapidcheck-unstable-2018-09-27...

Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rapidcheck

Partial log (click to expand)

-- Installing: /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27/include/rapidcheck/state.h
-- Installing: /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27/include/rapidcheck/Traits.h
-- Installing: /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27/include/rapidcheck.h
-- Installing: /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27/share/rapidcheck/cmake/rapidcheckConfig.cmake
-- Installing: /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27/share/rapidcheck/cmake/rapidcheckConfig-release.cmake
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27/lib
patching script interpreter paths in /nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27
/nix/store/533pswmyc9ps37l8y7wwzk9cid15i9m3-rapidcheck-unstable-2018-09-27

@c0bw3b c0bw3b changed the title rapidcheck: init at git-20180927 rapidcheck: init at unstable-2018-09-27 Oct 8, 2018
@c0bw3b c0bw3b self-assigned this Oct 8, 2018
@c0bw3b c0bw3b merged commit 81b851c into NixOS:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants