Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local path to release notes in error message #48042

Merged
merged 1 commit into from Oct 8, 2018
Merged

Fix local path to release notes in error message #48042

merged 1 commit into from Oct 8, 2018

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Oct 8, 2018

The error message when produced when Nix is too old refers the user to a local
copy of the NixOS release notes, but the provided path is incorrect.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ttuegel
Fix local path to release notes in error message
9da2134 
The error message when produced when Nix is too old refers the user to a local
copy of the NixOS release notes, but the provided path is incorrect.
@ttuegel ttuegel requested a review from grahamc October 8, 2018 10:45
@ttuegel ttuegel requested a review from nbp as a code owner October 8, 2018 10:45
@grahamc
Copy link
Member

grahamc commented Oct 8, 2018

Thank you :)

@grahamc grahamc merged commit e6a33e7 into NixOS:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc Awaiting requested review from grahamc

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ttuegel @grahamc @GrahamcOfBorg