Various minor code cleanups found by scan-build #6948
Merged
+59
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosch123
reviewed
Oct 29, 2018
| @@ -154,6 +154,7 @@ static uint32 RotateRight(uint32 val, uint32 rot) | |||
| { | |||
| /* Do not rotate more than necessary */ | |||
| rot %= 32; | |||
| assert(rot > 0); | |||
There was a problem hiding this comment.
The point it that it shouldn't be, as then you're doing val << 32, which isn't defined all that well. If we want to just assume that it should be 0, that's a bit different.
That said, not sure why this exists at all, when ROR in bitmath_func.hpp exists.
|
The Doxygen config changes should probably be moved to a separate PR from the code cleanup. |
LordAro
force-pushed
the
scan-build-findings
branch
from
6391d50 to
8f7fbff
Compare
LordAro
changed the title
frosch123
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things found by running
scan-build sh -c './configure && make'with all checkers turned on. Mostly missing null checks and dead code. Vast numbers of false positives that were ignored.Documentation fixes were found by going through the output of
doxygen, ignoring missing documentation warnings. Nearly all fixed, but some left that aren't clear how to be fixed (usually related to attributes being referred to before they're declared? Maybe the explicit#could be removed)Commits are almost entirely self-contained, so probably best to review individually