Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doxygen update and warning fixes #6954

Merged
merged 2 commits into from Oct 31, 2018
Merged

Doxygen update and warning fixes #6954

merged 2 commits into from Oct 31, 2018

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Oct 30, 2018

Documentation fixes were found by going through the output of doxygen, ignoring missing documentation warnings. Nearly all fixed, but some left that aren't clear how to be fixed (usually related to attributes being referred to before they're declared? Maybe the explicit # could be removed)

Split off from #6948 , with previous comments addressed

@@ -256,8 +256,8 @@ DEF_CONSOLE_CMD(ConResetTile)

/**
* Scroll to a tile on the map.
* @param arg1 tile tile number or tile x coordinate.
* @param arg2 optionally tile y coordinate.
* param x tile number or tile x coordinate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will generate right.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trouble with the console commands is that they don't actually have "proper" parameters - once the #define expands, they have argc & argv, not whatever console commands actually take. Probably need a better way of documenting console commands generally, but I decided that was out of scope for what I was trying to do (fix warnings)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might work to use the @fn command to introduce the functions, and then you should be allowed to use @param as well. But it would still not match up with the C++ function signature if you document the "logical" parameters... yeah, not going to work.

src/console.cpp Outdated Show resolved Hide resolved
src/console_cmds.cpp Show resolved Hide resolved
src/osk_gui.cpp Outdated Show resolved Hide resolved
src/station_base.h Show resolved Hide resolved
@LordAro LordAro force-pushed the doxyfix branch 2 times, most recently from 4a7a4c1 to 96bfecc Compare October 30, 2018 21:14
@frosch123 frosch123 merged commit f5b1115 into OpenTTD:master Oct 31, 2018
@LordAro LordAro deleted the doxyfix branch November 17, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants