libgit2: bump for bug fixes as well as security fixes #49494
Merged
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.27.6 is a security fix release Notes: https://github.com/libgit2/libgit2/releases/tag/v0.27.7 https://github.com/libgit2/libgit2/releases/tag/v0.27.6
0.26.7 is a security fix release 0.26.8 is a security fix release Notes: https://github.com/libgit2/libgit2/releases/tag/v0.26.8 https://github.com/libgit2/libgit2/releases/tag/v0.26.7
* match major libgit2 version * upstream patch to remove unnecessary requirement
|
Success on aarch64-linux (full log) Attempted: libgit2 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: libgit2 Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libgit2 Partial log (click to expand)
|
6 tasks
|
@dtzWill, quick question: what is the reason we can't move to 0.27 as default? IIRC, only 0.27 supports |
|
It likely can be made the default, although I'm not sure.
Quick grep suggests libgit2-glib may require the 0.26 version,
but perhaps that should be special-cased.
There may be other packages in similar situation, didn't check closely.
Regardless I'm not aware of a breakage-based reason it can't be default,
only that some packages need older version for presumably API reasons
and can be handled by specifying the 0.26 attribute
(which would be introduced).
Maybe give this a try and submit a PR? :)
…On Wed, 31 Oct 2018 10:02:05 -0700, qolii ***@***.***> wrote:
@dtzWill, quick question: what is the reason we can't move to 0.27 as default? IIRC, only 0.27 supports `libressl-2.7` and up. Does it break somethings?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#49494 (comment) part: text/html
|
|
Ping? Not sure if we mean to block or not just checking :) |
|
Overdue security fixes-- changing the default can be done separately (and sounds good but needs to be tested). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump pygit2 as well, not tested beyond building.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)