Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

curl: 7.61.1 -> 7.62.0 #49514

Merged
merged 1 commit into from Nov 2, 2018
Merged

curl: 7.61.1 -> 7.62.0 #49514

merged 1 commit into from Nov 2, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 31, 2018

See
#49463 (comment)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/iply3xi993vhmiwpa86k47vxbjdj4i08-curl-7.62.0-man
checking for references to /build in /nix/store/iply3xi993vhmiwpa86k47vxbjdj4i08-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/9rhrj2hgfwcsllr9vf5pf2h1d7fg7qhx-curl-7.62.0-devdoc
gzipping man pages under /nix/store/9rhrj2hgfwcsllr9vf5pf2h1d7fg7qhx-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/9rhrj2hgfwcsllr9vf5pf2h1d7fg7qhx-curl-7.62.0-devdoc
checking for references to /build in /nix/store/9rhrj2hgfwcsllr9vf5pf2h1d7fg7qhx-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/8cslc6j0ggkp1z03wssk1iwc04314j4y-curl-7.62.0-debug
patching script interpreter paths in /nix/store/8cslc6j0ggkp1z03wssk1iwc04314j4y-curl-7.62.0-debug
checking for references to /build in /nix/store/8cslc6j0ggkp1z03wssk1iwc04314j4y-curl-7.62.0-debug...
/nix/store/3hf4k9vk4fcq9xrvsgzi1nn3zlclyl4c-curl-7.62.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: curl

Partial log (click to expand)

patching script interpreter paths in /nix/store/xmnx20iv934wimacdqdazc6p4bi2ybhx-curl-7.62.0-man
checking for references to /build in /nix/store/xmnx20iv934wimacdqdazc6p4bi2ybhx-curl-7.62.0-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/rnspqsph4nf1rjsxs73sjf21mj4jn9qc-curl-7.62.0-devdoc
gzipping man pages under /nix/store/rnspqsph4nf1rjsxs73sjf21mj4jn9qc-curl-7.62.0-devdoc/share/man/
patching script interpreter paths in /nix/store/rnspqsph4nf1rjsxs73sjf21mj4jn9qc-curl-7.62.0-devdoc
checking for references to /build in /nix/store/rnspqsph4nf1rjsxs73sjf21mj4jn9qc-curl-7.62.0-devdoc...
shrinking RPATHs of ELF executables and libraries in /nix/store/rg27vyixg2amvzc2hwzd0msl3lz8pxf5-curl-7.62.0-debug
patching script interpreter paths in /nix/store/rg27vyixg2amvzc2hwzd0msl3lz8pxf5-curl-7.62.0-debug
checking for references to /build in /nix/store/rg27vyixg2amvzc2hwzd0msl3lz8pxf5-curl-7.62.0-debug...
/nix/store/c77l0vdlggpzri9mvfsmbdjzllvzid6c-curl-7.62.0-bin

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: curl

Partial log (click to expand)

cannot build derivation '/nix/store/6sbdv3zn2a6lzcmd1hc653qal6acfl2y-help2man-1.47.7.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/53zbm7m72rwmjdnjmkvm58ddimnfbakn-libssh2-1.8.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/782sbha7i1c90y7hyh3si8vqhhplvcgb-nghttp2-1.34.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/5i78p9ji5r4bkxmnmjmdw0fs621h9d94-libtool-2.4.6.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/j126gpqlwvcszgdd3ygh3djzhv7636d9-hook.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/1vjzh3hz1k9yw78g0mh4ivzjxbq7n7d2-flex-2.6.4.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/xpq0v4jwd00n0cmnrj7xgrpv6520iv10-bootstrap_cmds-dev-tools-7.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/fdxnlmdmyn7pnvzljwnc4kd57a7zkwv0-libkrb5-1.15.2.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/g639bgw8k26q08f5qns785l9p5lpgcaf-curl-7.62.0.drv': 7 dependencies couldn't be built
error: build of '/nix/store/g639bgw8k26q08f5qns785l9p5lpgcaf-curl-7.62.0.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2018

Backport needed.

@dtzWill dtzWill merged commit d604215 into NixOS:staging Nov 2, 2018
@dtzWill dtzWill deleted the update/curl-7.62.0 branch November 2, 2018 08:55
This was referenced Nov 12, 2018
Closed
Merged
@c0bw3b c0bw3b mentioned this pull request Nov 19, 2018
Closed
@obadz
Copy link
Contributor

obadz commented Nov 24, 2018

This breaks the build of fbreader with the following error:

make[2]: Entering directory '/build/source/zlibrary/core/src/unix/curl'
Compiling ZLCurlNetworkManager.o ...ZLCurlNetworkManager.cpp: In member function 'virtual std::__cxx11::string ZLCurlNetworkManager::perform(const Vector&) const':
ZLCurlNetworkManager.cpp:288:5: error: duplicate case value
     case CURLE_SSL_CACERT:
     ^~~~
ZLCurlNetworkManager.cpp:282:5: note: previously used here
     case CURLE_PEER_FAILED_VERIFICATION:
     ^~~~
make[2]: *** [/build/source/zlibrary/core/../../makefiles/subdir.mk:15: ZLCurlNetworkManager.o] Error 1
make[2]: Leaving directory '/build/source/zlibrary/core/src/unix/curl'
make[1]: *** [Makefile:41: .objects] Error 1
make[1]: Leaving directory '/build/source/zlibrary/core'
make: *** [Makefile:9: all] Error 1
builder for '/nix/store/68wwfvvga47pzjfwx2awzi49w5qbf8z6-fbreader-qt4-0.99.6.drv' failed with exit code 2

@obadz
Copy link
Contributor

obadz commented Nov 25, 2018

Mentioned in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913382 and apparently the breakage is due to this commit: curl/curl@3f3b26d

@obadz obadz mentioned this pull request Nov 25, 2018
Open
@vcunat
Copy link
Member

vcunat commented Nov 25, 2018

With this update curl no longer accepts http URL by IPv6 address. That's a bug, right?

$ curl 'http://[fd60:cc69:b537:1:96d:6b5:3a83:e4fa]'
curl: (3) URL using bad/illegal format or missing URL

(example taken from our failing ipv6 test)

@vcunat
Copy link
Member

vcunat commented Nov 25, 2018 •
edited

Oh, never mind me: 90720d0, a7fd431.

@obadz obadz mentioned this pull request Dec 1, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @GrahamcOfBorg @obadz @vcunat @fpletz