Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activation-script: add libc to path to provide nscd when needed #49513

Merged
merged 1 commit into from Nov 2, 2018
Merged

activation-script: add libc to path to provide nscd when needed #49513

merged 1 commit into from Nov 2, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 31, 2018

Motivation for this change

Missed when removing hardcoded glibc references, sorry.

In my defense comment claims glibc bin was used only for getent :).
Now we know better :).

(#49504)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Oops my bad! Why does it need nscd?

@dtzWill
Copy link
Member Author

dtzWill commented Oct 31, 2018 via email

@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2018

Someone asked about this on IRC today fwiw.

@dtzWill dtzWill merged commit 1fe7abc into NixOS:master Nov 2, 2018
@dtzWill dtzWill deleted the fix/activation-nscd-path branch November 2, 2018 08:57
@matthewbauer
Copy link
Member

Hopefully we can move to unscd and totally get rid of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @matthewbauer @GrahamcOfBorg