Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eternal-terminal: 5.1.7 -> 5.1.8. #49505

Merged
merged 2 commits into from Oct 31, 2018
Merged

eternal-terminal: 5.1.7 -> 5.1.8. #49505

merged 2 commits into from Oct 31, 2018

Conversation

qolii
Copy link
Contributor

@qolii qolii commented Oct 31, 2018

Motivation for this change

Standard version bump. Briefly tested, works fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build eternal-terminal

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eternal-terminal

Partial log (click to expand)

shrinking /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8/bin/htmd
shrinking /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8/bin/htm
shrinking /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8/bin/et
shrinking /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8/bin/etterminal
shrinking /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8/bin/etserver
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8/bin
patching script interpreter paths in /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8
checking for references to /build in /nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8...
/nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eternal-terminal

Partial log (click to expand)

-- Installing: /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8/bin/etserver
-- Installing: /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8/bin/etterminal
-- Installing: /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8/bin/et
-- Installing: /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8/bin/htm
-- Installing: /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8/bin/htmd
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8/bin
patching script interpreter paths in /nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8
/nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eternal-terminal

Partial log (click to expand)

shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/etserver
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/htm
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/et
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/etterminal
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/htmd
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin
patching script interpreter paths in /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8
checking for references to /build in /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8...
/nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8

@xeji xeji force-pushed the eternal-terminal__5_1_7__5_1_8 branch from 11dac4a to c970b4e Compare October 31, 2018 18:12
@xeji
Copy link
Contributor

xeji commented Oct 31, 2018

@GrahamcOfBorg build eternal-terminal

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: eternal-terminal

Partial log (click to expand)

/nix/store/gh1dghzc9d6qwc1wyv9vnfgcfcf6z815-eternal-terminal-5.1.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eternal-terminal

Partial log (click to expand)

/nix/store/7acqkm7frz1qpb0gdw30kmdxx1s8qrjs-eternal-terminal-5.1.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eternal-terminal

Partial log (click to expand)

shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/etterminal
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/htm
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/et
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/etserver
shrinking /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin/htmd
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8/bin
patching script interpreter paths in /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8
checking for references to /build in /nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8...
/nix/store/c3pj5mmigj8wdwkd81i3vlr1ycyw5l9r-eternal-terminal-5.1.8

@qolii
Copy link
Contributor Author

qolii commented Oct 31, 2018

Ah, good catch @xeji. Thanks for updating that.

@xeji
Copy link
Contributor

xeji commented Oct 31, 2018 •
edited

You're welcome 😄 I also rebased to solve a merge conflict. Looks good now.

@xeji xeji merged commit 5f75542 into NixOS:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qolii @xeji @GrahamcOfBorg