Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libversion: 2.7.0 -> 2.8.1; py-libversion: 1.0.0 -> 1.1.2 #49502

Closed
wants to merge 2 commits into from
Closed

libversion: 2.7.0 -> 2.8.1; py-libversion: 1.0.0 -> 1.1.2 #49502

wants to merge 2 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Oct 31, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner October 31, 2018 03:15
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libversion

Partial log (click to expand)

-- Installing: /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1/bin/version_compare
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1
shrinking /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1/bin/version_compare
shrinking /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1/lib/libversion.so.0.1.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1/lib  /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1/bin
patching script interpreter paths in /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1
checking for references to /build in /nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1...
/nix/store/yzcwcyrq69x2qkh3dxgg00bdfypdj5i0-libversion-2.8.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libversion

Partial log (click to expand)

-- Installing: /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1/bin/version_compare
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1
shrinking /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1/bin/version_compare
shrinking /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1/lib/libversion.so.0.1.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1/lib  /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1/bin
patching script interpreter paths in /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1
checking for references to /build in /nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1...
/nix/store/xzqh0a5cbhr10pv6dw72cz693lvnhy3h-libversion-2.8.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libversion

Partial log (click to expand)

-- Installing: /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/lib/libversion.0.dylib
-- Installing: /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/lib/libversion.dylib
-- Installing: /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/lib/libversion.a
-- Installing: /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/lib/pkgconfig/libversion.pc
-- Installing: /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/bin/version_compare
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/lib  /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1/bin
patching script interpreter paths in /nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1
/nix/store/88ah1mk9vv70wmivf3bkab1kimvmbx7q-libversion-2.8.1

@FRidh
Copy link
Member

FRidh commented Oct 31, 2018

@GrahamcOfBorg build python3.pkgs.libversion

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3.pkgs.libversion

Partial log (click to expand)

test_pyversion_compare_flag_any_is_patch (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_flag_p_is_patch (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_lg (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_ne (tests.test_pyversion.TestLibVersion) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.001s

OK
/nix/store/xxjrslfjjzdyq88xzlicn3hh7ny3qiz6-python3.6-libversion-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.libversion

Partial log (click to expand)

test_pyversion_compare_flag_any_is_patch (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_flag_p_is_patch (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_lg (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_ne (tests.test_pyversion.TestLibVersion) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.001s

OK
/nix/store/0k8i0nfbdlryswaiybns9bdlrmm0sbgp-python3.6-libversion-1.1.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.libversion

Partial log (click to expand)

test_pyversion_compare_flag_any_is_patch (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_flag_p_is_patch (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_lg (tests.test_pyversion.TestLibVersion) ... ok
test_pyversion_compare_ne (tests.test_pyversion.TestLibVersion) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.002s

OK
/nix/store/7hcc6zp116z6f8gir8wndnj5s6wmyxb1-python3.6-libversion-1.1.2

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2018

@dtzWill can you drop the commit for python3Packages.libversion please?
It's been updated in #49971

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 19, 2018

--> #50705

@c0bw3b c0bw3b closed this Nov 19, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Nov 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @GrahamcOfBorg @FRidh @c0bw3b