Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Musl/Glibc fixes #49504

Merged
merged 5 commits into from Oct 31, 2018
Merged

Musl/Glibc fixes #49504

merged 5 commits into from Oct 31, 2018

Conversation

matthewbauer
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

dtzWill and others added 5 commits October 30, 2018 19:47
@dtzWill @matthewbauer
stage1 boot: use stdenv.cc.libc
2d0ec8b 
(cherry picked from commit d3ae884)
@dtzWill @matthewbauer
nixos: use pkgs.getent and stdenv.cc.libc
9de0b28 
(cherry picked from commit 52eba97)
@dtzWill @matthewbauer
apparmor-suid: don't force glibc
afdf16b 
(cherry picked from commit 131131e)
@dtzWill @matthewbauer
gtk: don't hardcode glibc use
2603e3a 
(cherry picked from commit 6e6f839)
@tathougies @matthewbauer
nixos/networking.nix: only setup rpc on glibc
8cc028f 
(cherry picked from commit 4177dc3)
and
(cherry picked from commit a2f0c95)
@matthewbauer
Copy link
Member Author

@GrahamcOfBorg eval

@matthewbauer matthewbauer merged commit 7d24cf8 into NixOS:master Oct 31, 2018
@matthewbauer matthewbauer mentioned this pull request Oct 31, 2018
Closed
9 tasks
@dtzWill dtzWill mentioned this pull request Oct 31, 2018
Merged
9 tasks
@dtzWill
Copy link
Member

dtzWill commented Oct 31, 2018

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @dtzWill @GrahamcOfBorg @tathougies