Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03] Backport Signal-Desktop #48484

Merged
merged 12 commits into from Oct 15, 2018
Merged

[18.03] Backport Signal-Desktop #48484

merged 12 commits into from Oct 15, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Oct 15, 2018

Motivation for this change

Reason: Signal-Desktop displayed the following message: "This version of Signal Desktop has expired. Please upgrade to the latest version to continue messaging." (see #48436).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

primeos and others added 12 commits October 15, 2018 21:31
@primeos
signal-desktop: 1.14.1 -> 1.14.2
6aa8bc7 
(cherry picked from commit 4fd9ca3)
@primeos
signal-desktop: 1.14.2 -> 1.14.3
1160093 
(cherry picked from commit b68770c)
@primeos
signal-desktop: 1.14.3 -> 1.14.4
323491f 
(cherry picked from commit c89bdf9)
@primeos
signal-desktop: 1.14.4 -> 1.15.0
32eba88 
(cherry picked from commit 915e506)
@primeos
signal-desktop: Allow overriding the spell checker language (NixOS#44456
a1d4e98 
)

Thought this could be useful for others as well. Unfortunately it will
also override the UI language.

Example usage:

  environment.systemPackages = with pkgs; [
    (signal-desktop.override {
      spellcheckerLanguage = "de_DE";
    })
  ];

(cherry picked from commit 9ef1406)
@primeos
signal-desktop: 1.15.0 -> 1.15.3
0c19b38 
Skipped 1.15.1 due to upstream issues (see GitHub), 1.15.2 and 1.15.3
should be fine (at least there are fewer issues).

(cherry picked from commit c7e0433)
@primeos
signal-desktop: 1.15.3 -> 1.15.4
51fc1ed 
(cherry picked from commit b28f8b4)
@primeos
signal-desktop: 1.15.4 -> 1.15.5
600065e 
(cherry picked from commit 9f4e76b)
@primeos
signal-desktop: 1.15.5 -> 1.16.0
ce97b86 
(cherry picked from commit 7c1b85c)
@primeos
signal-desktop: 1.16.0 -> 1.16.1
acc9de0 
(cherry picked from commit 3410dcd)
@primeos
signal-desktop: 1.16.1 -> 1.16.2
1f8f5b1 
(cherry picked from commit a526719)
@tobiasBora @primeos
signal-desktop: enable notifications
17f1e9b 
(cherry picked from commit 820e1ca)
@primeos primeos added the 8.has: port to stable A PR already has a backport to the stable release. label Oct 15, 2018
@primeos primeos self-assigned this Oct 15, 2018
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: signal-desktop

Partial log (click to expand)

copying path '/nix/store/109rigjz7m9xkqrxy2igfv5ndc76ik7a-cairo-1.14.10' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/mngx0as54sc57rwwgwvyxpdzc8h66hlg-libxkbcommon-0.7.2' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/s96v1m6zjphfq3lpkfk7lfg2qcm15fbr-pango-1.40.14' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/qhymj46c3vb5sd5kcc182cavdab26vg5-gtk+3-3.22.28' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/xpcvlwv1rhi8j3vj8dxhvx1mjnh00irx-librsvg-2.42.2' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/iv86gayqsx3j6751yiksj3jcwij2prlb-hook' from 'https://nix-cache.s3.amazonaws.com'...
building '/nix/store/kjxvnam9y9wlim608lz811jra9qv2gp7-signal-desktop-1.16.2.drv'...
unpacking sources
installing
/nix/store/j1v8032aq2v5pgr0haxybjbrlpxv4sxd-signal-desktop-1.16.2

@primeos primeos merged commit ed819d8 into NixOS:release-18.03 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @GrahamcOfBorg @tobiasBora