Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql-jdbc: 42.2.2 -> 42.2.5 #48474

Merged
merged 1 commit into from Oct 15, 2018
Merged

postgresql-jdbc: 42.2.2 -> 42.2.5 #48474

merged 1 commit into from Oct 15, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 15, 2018 •
edited

Motivation for this change

Version bump mostly for bug fixing but also one CVE fix :

Security: added server hostname verification for non-default SSL factories in sslmode=verify-full (CVE-2018-10936)

Regarding the licensing :
pgjdbc/pgjdbc#660
https://github.com/pgjdbc/pgjdbc/blob/master/LICENSE
https://jdbc.postgresql.org/about/license.html

And I removed the underscore in the install rule to avoid breaking the package with #26839

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
postgresql-jdbc: 42.2.2 -> 42.2.5
adf9c50 
¤ set read-only permissions on .jar at install (mode 0444)
¤ license is now BSD 2-clause
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 15, 2018 •
edited

cc @yorickvP @Mic92 for review maybe? :)

On nixos-18.09:

Result in /tmp/nox-review-2lh_spk_
total 8
lrwxrwxrwx 1 demo users 66 15 oct.  20:51 result -> /nix/store/h239hrv5qsgxsfxchbhc4akd2xr6f3dr-postgresql-jdbc-42.2.5
lrwxrwxrwx 1 demo users 62 15 oct.  20:51 result-2 -> /nix/store/wp5cm83r4a5cs7i8dyg19dszd1kx6fq2-squirrel-sql-3.8.1

@Mic92 Mic92 merged commit af496ba into NixOS:master Oct 15, 2018
@c0bw3b c0bw3b deleted the pkg/pgjdbc branch October 15, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @Mic92 @GrahamcOfBorg