Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.paho-mqtt: 1.1 -> 1.4.0 #48473

Closed
wants to merge 1 commit into from
Closed

pythonPackages.paho-mqtt: 1.1 -> 1.4.0 #48473

wants to merge 1 commit into from

Conversation

andir
Copy link
Member

@andir andir commented Oct 15, 2018 •
edited

Motivation for this change

Updated to the latest stable release.

cc @mogorman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@andir andir requested a review from FRidh as a code owner October 15, 2018 17:41
@flokli
Copy link
Contributor

flokli commented Oct 16, 2018

@GrahamcOfBorg build python3Packages.paho-mqtt python2Packages.paho-mqtt

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python3Packages.paho-mqtt, python2Packages.paho-mqtt

Partial log (click to expand)

src/paho/mqtt/__init__.py .                                              [ 92%]
src/paho/mqtt/client.py .                                                [ 94%]
src/paho/mqtt/matcher.py .                                               [ 96%]
src/paho/mqtt/publish.py .                                               [ 98%]
src/paho/mqtt/subscribe.py .                                             [100%]

========================== 56 passed in 11.24 seconds ==========================
pytestcachePhase
/nix/store/61xin7xbayscicjjkyzj2rw8j902mx71-python3.6-paho-mqtt-1.4.0
/nix/store/9zc84nxnvd24djh8mwwgl20a389xvz3d-python2.7-paho-mqtt-1.4.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python3Packages.paho-mqtt, python2Packages.paho-mqtt

Partial log (click to expand)

src/paho/__init__.py .                                                   [ 91%]
src/paho/mqtt/__init__.py .                                              [ 92%]
src/paho/mqtt/client.py .                                                [ 94%]
src/paho/mqtt/matcher.py .                                               [ 96%]
src/paho/mqtt/publish.py .                                               [ 98%]
src/paho/mqtt/subscribe.py .                                             [100%]

========================== 56 passed in 11.33 seconds ==========================
pytestcachePhase
error: build of '/nix/store/rcazj051fyr2ki28xm57gijbd2aczp1m-python3.6-paho-mqtt-1.4.0.drv' failed

@flokli
Copy link
Contributor

flokli commented Oct 16, 2018

tests fail on darwin. could you have a look?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3Packages.paho-mqtt, python2Packages.paho-mqtt

Partial log (click to expand)

src/paho/mqtt/__init__.py .                                              [ 92%]
src/paho/mqtt/client.py .                                                [ 94%]
src/paho/mqtt/matcher.py .                                               [ 96%]
src/paho/mqtt/publish.py .                                               [ 98%]
src/paho/mqtt/subscribe.py .                                             [100%]

========================== 56 passed in 10.10 seconds ==========================
pytestcachePhase
/nix/store/6m1bqdfajwclr5z8qca5iby2qw1yv8l5-python3.6-paho-mqtt-1.4.0
/nix/store/nlzm0qc8d7x8vlwqv3a4chry5hm9hi7v-python2.7-paho-mqtt-1.4.0

FRidh
FRidh reviewed Oct 17, 2018
View reviewed changes
pkgs/development/python-modules/paho-mqtt/default.nix
sha256 = "1xg9ppz2lqacd9prsrx93q2wfkjjyla03xlfw74aj1alz9ki5hrs";
};

buildInputs = [ pylama ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is used for tests, or not? If so, it should be in checkInputs. Also, I think we can avoid including it altogether as it doesn't really make much sense having it running in our build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylama is a linter - right, we don't necessarily need to lint the codebase, although I'd still suggest to keep running the unit tests ;-)

@andir
Copy link
Member Author

andir commented Oct 23, 2018

Closing as someone else already pushed a similar change.

@andir andir closed this Oct 23, 2018
@andir andir deleted the paho-mqtt branch October 23, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @flokli @GrahamcOfBorg @FRidh