tikzit: init at 2.0 #48479

iblech · 2018-10-15T18:49:56Z

Motivation for this change

tikzit is a graphical editor for TikZ diagrams (for inclusion in LaTeX files). This pull requests adds tikzit to our repository.

The current version of tikzit is 2.0-rc2. I suggest we wait for 2.0 to be released before including tikzit in nixpkgs, to reduce clutter.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Merged efforts between iblech and mgttlinger

iblech · 2018-10-16T10:34:08Z

Thank you, Merlin!

TikZiT is indeed GPL3 Plus. The website doesn't communicate this clearly (a fix is already in the making), but the source code comments clearly state so.

iblech · 2018-10-18T14:03:23Z

Dear @mgttlinger, there just was a commit on the TikZiT repository changing the behavior of make install. This might affect our Nix build.

I don't have time right now to look into this, but will do so on the weekend. In case you want to go ahead right now, feel free to do so, of course.

mgttlinger · 2018-10-18T14:18:51Z

@iblech Given that we target the released version the new commit won't be in the version we pull, but we should definitely look into that for the next release.

iblech · 2018-10-21T17:33:33Z

@mgttlinger I'm happy to report that we don't need our preBuild kludge anymore; just setting the PREFIX variable is enough.

mgttlinger · 2018-10-22T05:30:15Z

@iblech That's great, now the build looks really clean. Should we remove the "do not merge" from the title?

iblech · 2018-10-23T12:32:16Z

I just pushed the necessary changes to that we target the just-released version 2.0.

@mgttlinger, it was a pleasure collaborating with you on this build! :-)

Dear committers, this pull request is no longer work in progress. Please consider it for merging.

c0bw3b

Also consider:

adding enableParallelBuilding = true; after checking it doesn't break the build
there seems to be unit tests available (not sure) :

  doCheck = true;
  checkTarget = "test";

c0bw3b · 2018-10-25T08:11:46Z

pkgs/tools/typesetting/tikzit/default.nix

+      can be included directly in papers typeset using LaTeX.
+    '';
+    homepage = https://tikzit.github.io/;
+    license = stdenv.lib.licenses.gpl3Plus;


licenses.gpl3Plus is enough since you have with stdenv.lib; at the opening of your meta block

c0bw3b · 2018-10-25T08:12:42Z

pkgs/tools/typesetting/tikzit/default.nix

+    '';
+    homepage = https://tikzit.github.io/;
+    license = stdenv.lib.licenses.gpl3Plus;
+    platforms = stdenv.lib.platforms.all;


Same reason: platforms.all

By the way, have you been able to test the build on Darwin/macOS ?

mgttlinger · 2018-10-25T09:24:11Z

About the tests: a make target test doesn't seem to exist. I can look into that later.

mgttlinger · 2018-10-25T14:19:25Z

Ok, so the make target is the default check but it doesn't seem to actually check anything

make: Nothing to be done for 'check'.

c0bw3b · 2018-10-25T15:27:03Z

Bah no worries, checks are not mandatory per se.
I just thought maybe there was some and that we could run them, but if it's not applicable to this package we'll live without it. :)

On the platforms topic : has one of you been able to test the build on macOS?

c0bw3b · 2018-10-25T15:28:02Z

@GrahamcOfBorg build tikzit

mgttlinger · 2018-10-25T15:35:31Z

@c0bw3b There seem to be tests if you look at the end of the tikzit.pro file but I am unsure how to activate them. I have neither a Mac nor a Win machine at hand for testing. Don't know about @iblech.

GrahamcOfBorg · 2018-10-25T15:42:49Z

Success on aarch64-linux (full log)

Attempted: tikzit

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/73lczdqv3k7wbbq4j5r62w07627pi0hw-tikzit-2.0
shrinking /nix/store/73lczdqv3k7wbbq4j5r62w07627pi0hw-tikzit-2.0/bin/tikzit
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/73lczdqv3k7wbbq4j5r62w07627pi0hw-tikzit-2.0/bin
patching script interpreter paths in /nix/store/73lczdqv3k7wbbq4j5r62w07627pi0hw-tikzit-2.0
checking for references to /build in /nix/store/73lczdqv3k7wbbq4j5r62w07627pi0hw-tikzit-2.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/73lczdqv3k7wbbq4j5r62w07627pi0hw-tikzit-2.0

iblech · 2018-10-25T15:44:12Z

Thank you for the feedback, @c0bw3b, and thank you for implementing the improvements, @mgttlinger!

I also can't test on Mac or Win, and I also didn't figure out how to activate the tests. The project description file tikzit.pro does have a conditional clause for making the resulting Makefile build the test suite, but I failed to find out how to activate this flag. No target of the standard Makefile generated by qmake will compile the test suite, hence in my understanding the make check doesn't actually do anything.

GrahamcOfBorg · 2018-10-25T15:44:21Z

Success on x86_64-linux (full log)

Attempted: tikzit

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vyaq1x6kgkz5ksgw0dqjaayxh4qbld82-tikzit-2.0
shrinking /nix/store/vyaq1x6kgkz5ksgw0dqjaayxh4qbld82-tikzit-2.0/bin/tikzit
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vyaq1x6kgkz5ksgw0dqjaayxh4qbld82-tikzit-2.0/bin
patching script interpreter paths in /nix/store/vyaq1x6kgkz5ksgw0dqjaayxh4qbld82-tikzit-2.0
checking for references to /build in /nix/store/vyaq1x6kgkz5ksgw0dqjaayxh4qbld82-tikzit-2.0...
postPatchMkspecs
postPatchMkspecs
/nix/store/vyaq1x6kgkz5ksgw0dqjaayxh4qbld82-tikzit-2.0

mgttlinger · 2018-10-25T15:45:30Z

Note that the travis config in the upstream repo doesn't run those tests either (it seems) so no idea how "maintained" they are anyway.

c0bw3b · 2018-10-25T17:02:22Z

Should be fine, upstream doesn't document special steps for building on Darwin.
Win is out of scope. Nix mostly targets x64 Linux, aarch64 (ARMv8) and Darwin (macOS)

* tikzit: init at 2.0 * tikzit: Parallel building and qualification

tikzit: init at 2.0-rc2

d199077

iblech mentioned this pull request Oct 15, 2018

NixOS package tikzit/tikzit#26

Closed

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 15, 2018

iblech mentioned this pull request Oct 16, 2018

Nix build tikzit/tikzit#27

Closed

mgttlinger mentioned this pull request Oct 16, 2018

tikzit: init at 2.0-rc2 #48527

Closed

9 tasks

mgttlinger added 2 commits October 16, 2018 10:40

Merged efforts between iblech and mgttlinger

30fab95

Merge pull request #1 from mgttlinger/patch-1

154bf05

Merged efforts between iblech and mgttlinger

tikzit: 2.0-rc2 -> 2.0-rc3

798f16d

iblech added 4 commits October 22, 2018 20:40

tikzit: get rid of now-superfluous preBuild hook

8b635ab

tikzit: ensure updates are checked over HTTPS

8351da1

tikzit: remove now-superfluous HTTPS fix

04169b5

tikzit: 2.0-rc3 -> 2.0

efc3f99

iblech changed the title ~~tikzit: init at 2.0-rc2 (WIP, do not merge yet)~~ tikzit: init at 2.0 Oct 23, 2018

c0bw3b reviewed Oct 25, 2018

View reviewed changes

tikzit: Parallel building and qualification

b6fe3e9

c0bw3b approved these changes Oct 25, 2018

View reviewed changes

c0bw3b merged commit 2595be0 into NixOS:master Oct 25, 2018

coreyoconnor pushed a commit to coreyoconnor/nixpkgs that referenced this pull request Oct 26, 2018

tikzit: init at 2.0 (NixOS#48479)

373845f

* tikzit: init at 2.0 * tikzit: Parallel building and qualification

symphorien mentioned this pull request Oct 29, 2018

tikzit: init at 2.0 #48885

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tikzit: init at 2.0 #48479

tikzit: init at 2.0 #48479

iblech commented Oct 15, 2018

iblech commented Oct 16, 2018

iblech commented Oct 18, 2018 •

edited

mgttlinger commented Oct 18, 2018

iblech commented Oct 21, 2018

mgttlinger commented Oct 22, 2018

iblech commented Oct 23, 2018

c0bw3b left a comment •

edited

c0bw3b Oct 25, 2018

c0bw3b Oct 25, 2018

mgttlinger commented Oct 25, 2018

mgttlinger commented Oct 25, 2018

c0bw3b commented Oct 25, 2018

c0bw3b commented Oct 25, 2018

mgttlinger commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

iblech commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

mgttlinger commented Oct 25, 2018

c0bw3b commented Oct 25, 2018 •

edited

tikzit: init at 2.0 #48479

tikzit: init at 2.0 #48479

Conversation

iblech commented Oct 15, 2018

Motivation for this change

Things done

iblech commented Oct 16, 2018

iblech commented Oct 18, 2018 • edited

mgttlinger commented Oct 18, 2018

iblech commented Oct 21, 2018

mgttlinger commented Oct 22, 2018

iblech commented Oct 23, 2018

c0bw3b left a comment • edited

Choose a reason for hiding this comment

c0bw3b Oct 25, 2018

Choose a reason for hiding this comment

c0bw3b Oct 25, 2018

Choose a reason for hiding this comment

mgttlinger commented Oct 25, 2018

mgttlinger commented Oct 25, 2018

c0bw3b commented Oct 25, 2018

c0bw3b commented Oct 25, 2018

mgttlinger commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

iblech commented Oct 25, 2018

GrahamcOfBorg commented Oct 25, 2018

mgttlinger commented Oct 25, 2018

c0bw3b commented Oct 25, 2018 • edited

iblech commented Oct 18, 2018 •

edited

c0bw3b left a comment •

edited

c0bw3b commented Oct 25, 2018 •

edited