Fix tiny typo #48477
Merged
Fix tiny typo #48477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Oct 15, 2018
| arguments, as well as the fact that it is easier to use (you can use the | ||
| same attribute names you see in your Nix code, instead of the ones | ||
| generated (e.g. <varname>buildInputs</varname> vs | ||
| <varname>nativeBuildInputs</varname>, and involves less typing. | ||
| <varname>nativeBuildInputs</varname>), and it involves less typing). |
There was a problem hiding this comment.
has another typo appeared here with the extra )?
There was a problem hiding this comment.
I don't believe so: before, the parentheses were not balanced. There were two opening parentheses and no closing ones.
There was a problem hiding this comment.
I think the PR is correct, the last paren closes the paren starting at "(you can use the ..." above. Parens within parens is perhaps not the best form, however.
EDIT: comment race :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a trivial typo fix.