Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd: 1.1.4 -> 1.2.0 #49101

Merged
merged 1 commit into from Oct 27, 2018
Merged

containerd: 1.1.4 -> 1.2.0 #49101

merged 1 commit into from Oct 27, 2018

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 25, 2018 •
edited

Signed-off-by: Vincent Demeester vincent@sbr.pm

Motivation for this change

Bump to latest containerd released. See https://github.com/containerd/containerd/releases/tag/v1.2.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vdemeester
containerd: 1.1.4 -> 1.2.0
a9c0329 
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@Mic92
Copy link
Member

Mic92 commented Oct 25, 2018

@GrahamcOfBorg build containerd

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: containerd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: containerd

Partial log (click to expand)

cannot find section .dynamic
shrinking /nix/store/kh8692sp9rm85ski60c68sadkhr00vnw-containerd-1.2.0/bin/containerd-stress
shrinking /nix/store/kh8692sp9rm85ski60c68sadkhr00vnw-containerd-1.2.0/bin/ctr
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kh8692sp9rm85ski60c68sadkhr00vnw-containerd-1.2.0/bin
patching script interpreter paths in /nix/store/kh8692sp9rm85ski60c68sadkhr00vnw-containerd-1.2.0
checking for references to /build in /nix/store/kh8692sp9rm85ski60c68sadkhr00vnw-containerd-1.2.0...
cannot find section .dynamic
cannot find section .dynamic
/nix/store/kh8692sp9rm85ski60c68sadkhr00vnw-containerd-1.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: containerd

Partial log (click to expand)

shrinking /nix/store/v7sc8hb9a3kc0289zy0dzpbyf5jkcf0p-containerd-1.2.0/bin/containerd-shim
cannot find section .dynamic
shrinking /nix/store/v7sc8hb9a3kc0289zy0dzpbyf5jkcf0p-containerd-1.2.0/bin/containerd
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v7sc8hb9a3kc0289zy0dzpbyf5jkcf0p-containerd-1.2.0/bin
patching script interpreter paths in /nix/store/v7sc8hb9a3kc0289zy0dzpbyf5jkcf0p-containerd-1.2.0
checking for references to /build in /nix/store/v7sc8hb9a3kc0289zy0dzpbyf5jkcf0p-containerd-1.2.0...
cannot find section .dynamic
cannot find section .dynamic
/nix/store/v7sc8hb9a3kc0289zy0dzpbyf5jkcf0p-containerd-1.2.0

@adisbladis adisbladis merged commit 549b61c into NixOS:master Oct 27, 2018
@vdemeester vdemeester deleted the update-containerd branch October 27, 2018 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vdemeester @Mic92 @GrahamcOfBorg @adisbladis