Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailcatcher: repackage using bundlerApp #49104

Merged
merged 1 commit into from Nov 5, 2018
Merged

mailcatcher: repackage using bundlerApp #49104

merged 1 commit into from Nov 5, 2018
+6 −24

Conversation

zarelit
Copy link
Member

@zarelit zarelit commented Oct 25, 2018 •
edited

Motivation for this change

Get to use new packaging standard for gems that are utilities

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 approved these changes Nov 5, 2018
View reviewed changes
pkgs/development/web/mailcatcher/default.nix

stdenv.mkDerivation rec {
name = "mailcatcher-${version}";
bundlerApp {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware of this feature. Is this documented in our nixpkgs manual?
I know that we have many packages are not make use of the exes attribute.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is: https://nixos.org/nixpkgs/manual/#sec-language-ruby

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mic92 It was introduced after many ruby apps were packaged already. Some of them are discoverable by looking at who provides "bundle" or "rspec" or "thor" for example. They're ruby tooling accidentally exposed for most of them.
I'll be hopefully able to make a PR to fix this soon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the function around bundler can be refactored a bit. I found them quite hard to follow.

@Mic92 Mic92 merged commit 5c63ee6 into NixOS:master Nov 5, 2018
@zarelit zarelit deleted the mailcatcher_rework branch June 25, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zarelit @Mic92 @GrahamcOfBorg