Fixes the package/options search user experience #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
caugner
commented
Oct 25, 2018
caugner
commented
- Doesn't discard input during load anymore.
- Makes the input more responsive by debouncing the filtering.
Previously, the search field was always overwritten with the current value from the location's hash, as soon as the packages/options list was loaded, and a modified search query during load was discarded.
samueldr
approved these changes
Nov 4, 2018
There was a problem hiding this comment.
If one wants to test the chances locally, there's a way in the chromium dev tools (and probably other browsers) to throttle the speed artificially:
In that box, switch to a slower mode, refresh, type things in the box, then change back to "online" (the alternative is to wait the full artificially throttled load, which is painful).
It is how I verified the behaviour (in addition to reading the code).
As for the debouncing, it's hard to "verify", formally, but it does feel better with the bigger package set.
|
This PR has been superseded by #209. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.