New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #46453 #48155
Backport #46453 #48155
Conversation
- Now correctly sets NIX_GHC* env vars
HI! Always nice to see backports. Though, I do not know whether this should be backported or not. I know next to nothing about the whole haskell world, and also close to nothing to the haskell things in Nixpkgs. You said: "there's a chance it might break some workflows" and "this shouldn't break any existing code". When not knowing what the original PR did, and even after a quick read through the original PR description, these statements seem antithetical. Is it possible to:
I think (hope) it would help gauge whether this update is relevant to backport. Thanks! |
@samuelrivas Yea, the "chance it might break some workflows" was intended to fit within the "shouldn't" part of "shouldn't break any existing code." i.e. it is a slight change in mechanism, so it's hard to say for sure that nothing will break even though it seems unlikely that anything would break. Basically, we've change My preference would be to do the backport:
|
quoting the right Samuel ;) @samueldr |
Can this be accepted? |
I agree this should be backported. I justed tested it and it works. I'll try to merge this tomorrow at the NixCon hackathon if nobody objects before that. |
Backporting #46453
Not sure if this is something we actually want to backport, since there's a chance it might break some workflows for anyone who's already upgraded to 18.09. But 18.09 is still pretty new, and this shouldn't break any existing code. So my preference would be to backport it.