Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scummvm: add several ScummVM supported games #48148

Merged
merged 1 commit into from Oct 21, 2018
Merged

scummvm: add several ScummVM supported games #48148

merged 1 commit into from Oct 21, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change
  • Beneath a Steel Sky: v1.2
  • Drascula: The Vampire Strikes Back: v2.0
  • Flight of the Amazon Queen: v1.1
  • Lure of the Temptress: v1.1

We could also wrap scummvm instead of course.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peterhoeg
scummvm: add several ScummVM supported games
a75b320 
 - Beneath a Steel Sky: v1.2
 - Drascula: The Vampire Strikes Back: v2.0
 - Flight of the Amazon Queen: v1.1
 - Lure of the Temptress: v1.1
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: scummvm

Partial log (click to expand)

these paths will be fetched (13.61 MiB download, 49.07 MiB unpacked):
  /nix/store/fpqsq0jmcwnzrdz1rshyh0hjhrgim0vc-scummvm-2.0.0
  /nix/store/jbfbppml8k79agbbw1nzv0il9qc4jcrv-libmad-0.15.1b
copying path '/nix/store/jbfbppml8k79agbbw1nzv0il9qc4jcrv-libmad-0.15.1b' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/fpqsq0jmcwnzrdz1rshyh0hjhrgim0vc-scummvm-2.0.0' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/fpqsq0jmcwnzrdz1rshyh0hjhrgim0vc-scummvm-2.0.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: scummvm

Partial log (click to expand)

copying path '/nix/store/zlm876qill7z37a53hhlbaaj4ldav4hb-speexdsp-1.2rc3' from 'https://cache.nixos.org'...
copying path '/nix/store/28ax9hc2pvgldg2wz6b59hhyfwz2a7bc-dbus-1.12.10-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/wj63r3c89pn77gmiml3bjq9cxms7zxyl-libxkbcommon-0.8.0' from 'https://cache.nixos.org'...
copying path '/nix/store/kwip6j1wihxddh4s3dk7g4rd4y6rl007-libjack2-1.9.12' from 'https://cache.nixos.org'...
copying path '/nix/store/7zrwnnprwwqkk3cyaarwv1a0gnwzm6y9-dconf-0.28.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/i2lyv6vpw15g7i3g8s2pp7zfpwq1vyrn-libpulseaudio-12.2' from 'https://cache.nixos.org'...
copying path '/nix/store/flxkwnnwvxa93dwvhjzf2sscz92wrwmk-SDL2-2.0.8' from 'https://cache.nixos.org'...
copying path '/nix/store/z73zbn6jvdmab3s4n4wi9hl2az9lk7px-fluidsynth-1.1.10' from 'https://cache.nixos.org'...
copying path '/nix/store/b2j6fwvaxz98akfm857jjx90jbxhkb95-scummvm-2.0.0' from 'https://cache.nixos.org'...
/nix/store/b2j6fwvaxz98akfm857jjx90jbxhkb95-scummvm-2.0.0

@c0bw3b c0bw3b merged commit d88d012 into NixOS:master Oct 21, 2018
@peterhoeg peterhoeg deleted the p/scummvm_games branch October 21, 2018 12:00
@peterhoeg peterhoeg restored the p/scummvm_games branch October 22, 2018 11:55
@peterhoeg peterhoeg deleted the p/scummvm_games branch March 18, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @GrahamcOfBorg @c0bw3b