Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Increase Virtualbox disk image size" #48151

Merged
merged 1 commit into from Oct 10, 2018
Merged

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Oct 10, 2018

Reverts #46649
and unbreak the build of nixos.ova.x86_64-linux ( https://hydra.nixos.org/build/82516491 )

@bjornfor
Copy link
Contributor

Uh oh. Why would hydra spend more time on the bigger (sparse) image? Are we sure this wasn't just a sporadic timeout? (I would really like to see the virtualbox image have more headroom, which is now unfortunately reverted.)

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Oct 25, 2018

We would like it too...
It's highly possible the Hydra failure was just a transient error, but at the time the revert was the right thing to do in order to unbreak things.
For the moment I haven't come around to try and build locally like it was suggested in #46649 ...

I think we should maybe start with a VHD/VDI disk image that could easily be resized by VirtualBox, rather than a fixed-size raw image inside of a VMDK wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants