Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qiskit: 0.5.7 -> 0.6.1 #48152

Merged
merged 3 commits into from Oct 11, 2018
Merged

qiskit: 0.5.7 -> 0.6.1 #48152

merged 3 commits into from Oct 11, 2018

Conversation

pandaman64
Copy link
Contributor

Motivation for this change

update 3 packages

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed Oct 10, 2018
View reviewed changes
pkgs/development/python-modules/qiskit/default.nix Outdated
@@ -2,6 +2,8 @@
, isPy3k
, buildPythonPackage
, fetchPypi
, fetchurl
, python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchurl and python are not used anywhere. Why add them?

pkgs/development/python-modules/qasm2image/default.nix Outdated

src = fetchFromGitHub {
owner = "nelimeee";
owner = "pandaman64";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for switching to a fork? It seems to be behind the original repo.

@pandaman64
Copy link
Contributor Author

pandaman64 commented Oct 11, 2018 •
edited

fixed contamination.

@xeji
Copy link
Contributor

xeji commented Oct 11, 2018

@GrahamcOfBorg build python36Packages.qiskit python36Packages.qasm2image python36Packages.IBMQuantumExperience python27Packages.IBMQuantumExperience

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python36Packages.qiskit, python36Packages.qasm2image, python36Packages.IBMQuantumExperience, python27Packages.IBMQuantumExperience

Partial log (click to expand)

[ OK ] Testing with '/private/tmp/nix-build-python3.6-qasm2image-0.8.0.drv-0/source/tests/examples/ibmqx2/W3test.qasm'
[ OK ] Testing with '/private/tmp/nix-build-python3.6-qasm2image-0.8.0.drv-0/source/tests/examples/invalid/gate_no_found.qasm'
"Cannot find gate definition for 'w', line 5 file "
Error near line 4 Column 2ate/tmp/nix-build-python3.6-qasm2image-0.8.0.drv-0/source/tests/examples/invalid/missing_semicolon.qasm'
[ OK ] Testing with '/private/tmp/nix-build-python3.6-qasm2image-0.8.0.drv-0/source/tests/examples/invalid/missing_semicolon.qasm'
"Invalid version string. Expected '2.0;'.  Is the semicolon missing?"
/nix/store/vb43cky6lgjbkqnx1ly973hj32brlaap-python3.6-qiskit-0.6.1
/nix/store/lllnsw5igbv9qr0g7abhxxpr00vpxjv1-python3.6-qasm2image-0.8.0
/nix/store/vw4lh9wa9yrx62dimw9m5klbgn03vnnw-python3.6-IBMQuantumExperience-2.0.3
/nix/store/87gx4hnqb4bh8bcmpigr5grb6319hl6c-python2.7-IBMQuantumExperience-2.0.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.qiskit, python36Packages.qasm2image, python36Packages.IBMQuantumExperience, python27Packages.IBMQuantumExperience

Partial log (click to expand)

[ OK ] Testing with '/build/source/tests/examples/ibmqx2/iswap.qasm'
[ OK ] Testing with '/build/source/tests/examples/ibmqx2/qe_qft_4.qasm'
[ OK ] Testing with '/build/source/tests/examples/ibmqx2/qe_qft_5.qasm'
[ OK ] Testing with '/build/source/tests/examples/ibmqx2/W3test.qasm'
[ OK ] Testing with '/build/source/tests/examples/ibmqx2/qe_qft_3.qasm'
[ OK ] Testing with '/build/source/tests/examples/ibmqx2/011_3_qubit_grover_50_.qasm'
/nix/store/gq27bamlirg6ab3ar1bslc34kdvjv9y5-python3.6-qiskit-0.6.1
/nix/store/wih8jb2in174b3z10843pq3pp98wcbc7-python3.6-qasm2image-0.8.0
/nix/store/ijwqlx2h1zbyigx2y1m25j5asy1jjk8i-python3.6-IBMQuantumExperience-2.0.3
/nix/store/d7zla6pgww4dzdhkc0yxrdcswyc44a96-python2.7-IBMQuantumExperience-2.0.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.qiskit, python36Packages.qasm2image, python36Packages.IBMQuantumExperience, python27Packages.IBMQuantumExperience

Partial log (click to expand)

[ OK ] Testing with '/build/source/tests/examples/generic/ipea_3_pi_8.qasm'
[ OK ] Testing with '/build/source/tests/examples/generic/inverseqft2.qasm'
[ OK ] Testing with '/build/source/tests/examples/generic/inverseqft1.qasm'
[ OK ] Testing with '/build/source/tests/examples/generic/bigadder.qasm'
[ OK ] Testing with '/build/source/tests/examples/generic/adder.qasm'
[ OK ] Testing with '/build/source/tests/examples/generic/W-state.qasm'
/nix/store/2g0pb1nxjnizm8xnc9234mk8qb1k3k9a-python3.6-qiskit-0.6.1
/nix/store/gdglas9kd46cmgygsiw08x1anqzvrfv0-python3.6-qasm2image-0.8.0
/nix/store/n3m6bi0cfcjiinyc7yip8mdng8ncwrn8-python3.6-IBMQuantumExperience-2.0.3
/nix/store/4d2lifkv9c75dy67hm9zq20s8b3j39yr-python2.7-IBMQuantumExperience-2.0.3

@xeji xeji merged commit 0586655 into NixOS:master Oct 11, 2018
@pandaman64 pandaman64 deleted the upgrade-qiskit branch October 14, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pandaman64 @xeji @GrahamcOfBorg