Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib.version: change from "pre-" to "post-" #48279

Closed
wants to merge 1 commit into from
Closed

lib.version: change from "pre-" to "post-" #48279

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Now that the release is out, I think the nixpkgs tree should identify
itself as 18.09post-git instad of 18.09pre-git.

This fixes snippets like this when building from git:

lib.versionOlder lib.version "18.09"

Before:

nix-repl> lib.versionOlder "18.09pre-git" "18.09"
true

After:

nix-repl> lib.versionOlder "18.09post-git" "18.09"
false

(It also fixes the opposite test, lib.versionAtLeast.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bjornfor
lib.version: change from "pre-" to "post-"
f1097e5 
Now that the release is out, I think the nixpkgs tree should identify
itself as 18.09post-git instad of 18.09pre-git.

This fixes snippets like this when building from git:

 lib.versionOlder lib.version "18.09"

Before:

  nix-repl> lib.versionOlder "18.09pre-git" "18.09"
  true

After:

  nix-repl> lib.versionOlder "18.09post-git" "18.09"
  false

(It also fixes the opposite test, lib.versionAtLeast.)
@xeji
Copy link
Contributor

xeji commented Oct 12, 2018 •
edited

We could also call it 19.03pre-git. I think this is how it was done for previous releases.

@xeji
Copy link
Contributor

xeji commented Oct 12, 2018

cc @samueldr @vcunat

@samueldr
Copy link
Member

samueldr commented Oct 12, 2018 •
edited

@xeji this PR targets release-18.09, so no, it wouldn't be 19.03pre-git (which it already is in master).

I'm not sure about this change, simply because this is something that wasn't done... ever? But not against the general idea!

When would the "18.09pre-git" (or "18.09post-git") be used? nixos-rebuild creates the relevant file when using a checkout for the system.

Assuming this change is wanted, I would prefer "18.09-git" instead of "post-git"; post-git seems weird to me.

Finally, maybe the solution isn't to add "pre-git" in versionSuffix, but to have "pre" be part of ".version" until it is released? What will break, if anything, if .version is 19.03pre until the fork and release?

@xeji
Copy link
Contributor

xeji commented Oct 12, 2018

Sorry, I didn't realize this was for 18.09...

@samueldr
Copy link
Member

(triage) closing, as stated this seems to be going the wrong way around, and this targets the penultimate release branch, which is not supported anymore anyway.

@samueldr samueldr closed this Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bjornfor @xeji @samueldr @GrahamcOfBorg