Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nheko: mark as insecure #48280

Closed
wants to merge 1 commit into from
Closed

nheko: mark as insecure #48280

wants to merge 1 commit into from

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Oct 12, 2018 •
edited

The package is no longer maintained and includes potential security
vulnerabilities (a use-after-free and several crashes) that are known
and not fixed in the version present in nixpkgs. They don't look too bad
judging from the trigger vectors mentioned in the changelog, but with
the project going unmaintained one of them becoming a security
vulnerability would likely not be noticed.

Backport of #48281

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ekleog
nheko: mark as insecure
158dd08 
The package is no longer maintained and includes potential security
vulnerabilities (a use-after-free and several crashes) that are known
and not fixed in the version present in nixpkgs. They don't look too bad
judging from the trigger vectors mentioned in the changelog, but with
the project going unmaintained one of them becoming a security
vulnerability would likely not be noticed.
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: nheko

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "nheko-0.5.5"
       ];
     }

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: nheko

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "nheko-0.5.5"
       ];
     }

@Ekleog Ekleog mentioned this pull request Oct 12, 2018
Merged
9 tasks
@xeji
Copy link
Contributor

xeji commented Oct 12, 2018

backported in 14bb2f4.

@Ekleog in most cases there's no need to open a separate PR for backporting, just mention in your PR against master that it needs to be backported. We prefer to backport using git cherry-pick -x to retain a reference to the original commit for easier tracking of changes.

@xeji xeji closed this Oct 12, 2018
@Ekleog
Copy link
Member Author

Ekleog commented Oct 13, 2018

Got it :) originally the PR on unstable completely dropped nheko, actually, and then I noticed someone else had updated it (so it was at the latest version and only needed a knownVulnerabilities)… sorry for having forgotten to close this one :)

@Ekleog Ekleog deleted the nheko-drop-18.09 branch October 13, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ekleog @GrahamcOfBorg @xeji