Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licenses #48291

Merged
merged 10 commits into from Oct 12, 2018
Merged

Add licenses #48291

merged 10 commits into from Oct 12, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Another round for #43716

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

xeji
xeji reviewed Oct 12, 2018
View reviewed changes
pkgs/development/libraries/gtkspell/default.nix Outdated
platforms = stdenv.lib.platforms.unix;
meta = with stdenv.lib; {
description = "Word-processor-style highlighting and replacement of misspelled words";
hompepage = http://gtkspell.sourceforge.net;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eval error because of typo: s/hompepage/homepage

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: airspy, grantlee, hspell, hunspell, hyena, id3lib, qt-gstreamer

Partial log (click to expand)

copying path '/nix/store/v1ls03msfzh3sw520hw5ni2lf9sg8sig-qt-4.8.7' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/7mnzkl4pr71izlbjm5k530kxb29fan9d-grantlee-0.5.1' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/jf7mldqgxmr8x97h2w2pjna8zkgfh2b8-qt-gstreamer-0.10.3' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/wf6ld5m15k3dmi59j9iax2wcdjrhq41a-airspy-1.0.9
/nix/store/7mnzkl4pr71izlbjm5k530kxb29fan9d-grantlee-0.5.1
/nix/store/fh5dk8wqz6aza0m9blbrvi2iriq3i89j-hspell-1.1
/nix/store/pll4zh9c8xq1xkw30fwmyk5zv10780jl-hunspell-1.6.2-bin
/nix/store/rmk90q12kzz7mq3vj87lhj20x4gwxzby-hyena-0.5
/nix/store/1x6ml9dn4znxhs0w4gdf402kc99ysf4l-id3lib-3.8.3
/nix/store/jf7mldqgxmr8x97h2w2pjna8zkgfh2b8-qt-gstreamer-0.10.3

@xeji xeji merged commit 0efb6e3 into NixOS:master Oct 12, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: airspy, grantlee, hspell, hunspell, id3lib, qt-gstreamer

The following builds were skipped because they don't evaluate on aarch64-linux: hyena

Partial log (click to expand)

     ^
gcc.link.dll bin.v2/libs/graph/build/gcc-7.3.0/release/threading-multi/libboost_graph.so.1.55.0
common.copy stage/lib/libboost_graph.so.1.55.0
ln-UNIX stage/lib/libboost_graph.so
...failed updating 3 targets...
...skipped 6 targets...
...updated 556 targets...
builder for '/nix/store/5vsfj4498kg1v56qxbvd1s7dyw6rg1fb-boost-1.55.0.drv' failed with exit code 1
cannot build derivation '/nix/store/2x6yry8yx7p8wccnirl4wfzbk3rfmjmv-qt-gstreamer-0.10.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/2x6yry8yx7p8wccnirl4wfzbk3rfmjmv-qt-gstreamer-0.10.3.drv' failed

@markuskowa markuskowa deleted the licenses-20 branch October 12, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @GrahamcOfBorg @xeji