Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblinear: 2.20 -> 2.21 #48304

Merged
merged 1 commit into from Oct 13, 2018
Merged

liblinear: 2.20 -> 2.21 #48304

merged 1 commit into from Oct 13, 2018

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Oct 13, 2018 •
edited

Motivation for this change

Primary change:

Since 2.20 we have continued to improve the conjugate gradient method in primal-based Newton solvers by applying a preconditioning technique. The convergence can be significantly improved on some problems.

https://www.csie.ntu.edu.tw/~cjlin/liblinear/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Oct 13, 2018

@GrahamcOfBorg build liblinear

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: liblinear

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21
shrinking /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21/lib/liblinear.3.so
shrinking /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21/bin/liblinear-predict
shrinking /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21/bin/liblinear-train
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21/lib  /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21/bin
patching script interpreter paths in /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21
checking for references to /build in /nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21...
/nix/store/fxnxyxmxfb0li9f3xwj5j92nw2cx9ks3-liblinear-2.21

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: liblinear

Partial log (click to expand)

        SHARED_LIB_FLAG="-dynamiclib -Wl,-install_name,liblinear.so.3"; \
else \
        SHARED_LIB_FLAG="-shared -Wl,-soname,liblinear.so.3"; \
fi; \
clang++ ${SHARED_LIB_FLAG} linear.o tron.o blas/blas.a -o liblinear.so.3
installing
post-installation fixup
strip is /nix/store/53nysl8bqwxihwzs1pgwka20nf8mbvlp-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/n7dp3vd5q2bdjadav7xpdwr64684h7ws-liblinear-2.21/lib  /nix/store/n7dp3vd5q2bdjadav7xpdwr64684h7ws-liblinear-2.21/bin
patching script interpreter paths in /nix/store/n7dp3vd5q2bdjadav7xpdwr64684h7ws-liblinear-2.21

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: liblinear

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21
shrinking /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21/bin/liblinear-predict
shrinking /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21/bin/liblinear-train
shrinking /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21/lib/liblinear.3.so
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21/lib  /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21/bin
patching script interpreter paths in /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21
checking for references to /build in /nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21...
/nix/store/6gfi5p5y50ihv6n32hkl0xlfw7hlilaa-liblinear-2.21

@xeji xeji merged commit c15006d into NixOS:master Oct 13, 2018
@danieldk danieldk deleted the liblinear-2.21 branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @xeji @GrahamcOfBorg