Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting OneCache to same location as local cache wipes all cached files #2537

Closed
politas opened this issue Oct 13, 2018 · 2 comments · Fixed by #2538
Closed

Setting OneCache to same location as local cache wipes all cached files #2537

politas opened this issue Oct 13, 2018 · 2 comments · Fixed by #2538
Assignees
@HebaruSan
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN

Comments

@politas
Copy link
Member

politas commented Oct 13, 2018

Post #2535, on initial run, if user has used the fairly common trick of making local CKAN/download folders a link to a single folder and creates a similar link as the new default shared cached location, all cached files are deleted on first load of a KSP instance.
@HebaruSan HebaruSan added Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN labels Oct 13, 2018
@politas
Copy link
Member Author

politas commented Oct 13, 2018

A second launch does not appear to delete items newly cached.

@HebaruSan
Copy link
Member

HebaruSan commented Oct 13, 2018 •
edited
Loading

  1. MoveFrom should be more cautious if possible, or stop deleting things at all
  2. MoveFrom shouldn't be getting called on the initial run. That should only happen when the user changes the setting, so there may be some problem with the logic the first time the new code runs.
  3. It was a mistake to move files automatically when the user edits the location in GUI. I messed up my home directory thanks to that just now.

@HebaruSan HebaruSan mentioned this issue Oct 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HebaruSan HebaruSan

Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop auto-moving cached files HebaruSan/CKAN
2 participants
@HebaruSan @politas