Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reattach-to-user-namespace: 2.6 -> 2.7 #48283

Merged
merged 1 commit into from Oct 12, 2018
Merged

reattach-to-user-namespace: 2.6 -> 2.7 #48283

merged 1 commit into from Oct 12, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Oct 12, 2018 •
edited

Motivation for this change

Adds macOS Mojave (10.14) support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
reattach-to-user-namespace: 2.6 -> 2.7
42088e0 
Adds macOS Mojave (10.14) support.
@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: reattach-to-user-namespace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: reattach-to-user-namespace

Partial log (click to expand)

clang -Wall -Wextra -ansi -pedantic -std=c99 -arch x86_64 -mmacosx-version-min=10.5   -c -o move_to_user_namespace.o move_to_user_namespace.c
clang -arch x86_64  test.o msg.o move_to_user_namespace.o   -o test
clang -Wall -Wextra -ansi -pedantic -std=c99 -arch x86_64 -mmacosx-version-min=10.5   -c -o reattach-to-user-namespace.o reattach-to-user-namespace.c
clang -arch x86_64  reattach-to-user-namespace.o msg.o move_to_user_namespace.o   -o reattach-to-user-namespace
installing
post-installation fixup
strip is /nix/store/9xjkb4xz0b5lmizij9ppxy7lkxdxhx6b-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0w5bsx2ndnjd8x4khj63qamnb9s5i497-reattach-to-user-namespace-2.7/bin
patching script interpreter paths in /nix/store/0w5bsx2ndnjd8x4khj63qamnb9s5i497-reattach-to-user-namespace-2.7
/nix/store/0w5bsx2ndnjd8x4khj63qamnb9s5i497-reattach-to-user-namespace-2.7

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: reattach-to-user-namespace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit d856710 into NixOS:master Oct 12, 2018
@LnL7 LnL7 deleted the reattach-to-user-namespace-2.7 branch October 13, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @xeji