Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPYING: move notice to README.md #48320

Merged
merged 1 commit into from Oct 13, 2018
Merged

COPYING: move notice to README.md #48320

merged 1 commit into from Oct 13, 2018

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Oct 13, 2018

Motivation for this change

See: #43575

Move notice to README.md so that GitHub identifies the license and offers metadata for it, as proposed by @matthewbauer. Also, minor notice rewording.

cc @copumpkin @grahamc @pSub @samueldr

@grahamc
Copy link
Member

grahamc commented Oct 13, 2018

cc @armijnhemel -- do you have any opinions?

otherwise, lgtm!

@armijnhemel
Copy link
Contributor

Personally I would not remove the COPYING file as it has been a convention for decades and people tend to look for either COPYING, LICENSE, LICENCE, and so on. A bit of duplication isn't a sin, as long as the info is kept in sync.

@armijnhemel
Copy link
Contributor

so to be clear: adding it to README.md is fine, just don't remove the COPYING file :-)

@lukateras
Copy link
Member Author

lukateras commented Oct 13, 2018

@armijnhemel This keeps COPYING file, just removes notice out of it. The rationale is that it makes GitHub recognize that license and offer user-friendly metadata. For example of how it's going to look like, see: https://github.com/NixOS/ofborg/blob/released/LICENSE

IANAL and all, but this notice seems to be purely informative and doesn't change actual licensing terms (and for legal purposes it wouldn't matter in which file it is anyway).

@armijnhemel
Copy link
Contributor

Right. IANAL either, but we can summon one (although it might take a few days for him to appear) @silverhook

@infinisil
Copy link
Member

@yegortimoshenko I'm not sure if this is because of it being a fork, but I don't see GitHub recognizing anything about the license in your branch: https://github.com/transumption/nixpkgs/blob/201810/move-notice-to-readme/COPYING

@lukateras
Copy link
Member Author

lukateras commented Oct 13, 2018

@infinisil It's because it was not in HEAD. I've pushed it to master and it's been recognized: https://github.com/transumption/nixpkgs/blob/master/COPYING

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, neat! It also shows on the main page btw: https://github.com/transumption/nixpkgs
(MIT on the top right)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 13, 2018

+1 on this.
Solves: #25705

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only "real" change in the text is this:

the Nix Packages collectionNixpkgs

which seems fine at first glance 👍

Copy link
Member

@copumpkin copumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lawyer but as previously discussed, I support this. Making licenses easier for humans/non-lawyers to process is a Good Thing IMO, and if this gets GitHub to present easy human-readable data to potential contributors, that's a win.

@copumpkin
Copy link
Member

Still curious on @silverhook's take on it, of course. If it's really essential we can add it back, but it seems unusual enough that we're probably fine without it?

@lukateras
Copy link
Member Author

lukateras commented Oct 13, 2018

FWIW, I think @silverhook already answered this question here: #43575 (comment)

Legally speaking it matters little whether you have the notice in the README or LICENSE or COPYING. I think it’s OK where it is, but it would just as well fit well in either README or even FAQ. Personally, I would keep license text canonical and add further info in README.

@silverhook
Copy link
Contributor

Yup, looks OK to me.

@copumpkin
Copy link
Member

Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants