-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
COPYING: move notice to README.md #48320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COPYING: move notice to README.md #48320
Conversation
cc @armijnhemel -- do you have any opinions? otherwise, lgtm! |
Personally I would not remove the COPYING file as it has been a convention for decades and people tend to look for either COPYING, LICENSE, LICENCE, and so on. A bit of duplication isn't a sin, as long as the info is kept in sync. |
so to be clear: adding it to README.md is fine, just don't remove the COPYING file :-) |
@armijnhemel This keeps IANAL and all, but this notice seems to be purely informative and doesn't change actual licensing terms (and for legal purposes it wouldn't matter in which file it is anyway). |
Right. IANAL either, but we can summon one (although it might take a few days for him to appear) @silverhook |
@yegortimoshenko I'm not sure if this is because of it being a fork, but I don't see GitHub recognizing anything about the license in your branch: https://github.com/transumption/nixpkgs/blob/201810/move-notice-to-readme/COPYING |
@infinisil It's because it was not in HEAD. I've pushed it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, neat! It also shows on the main page btw: https://github.com/transumption/nixpkgs
(MIT on the top right)
+1 on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only "real" change in the text is this:
the Nix Packages collection
→ Nixpkgs
which seems fine at first glance 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a lawyer but as previously discussed, I support this. Making licenses easier for humans/non-lawyers to process is a Good Thing IMO, and if this gets GitHub to present easy human-readable data to potential contributors, that's a win.
Still curious on @silverhook's take on it, of course. If it's really essential we can add it back, but it seems unusual enough that we're probably fine without it? |
FWIW, I think @silverhook already answered this question here: #43575 (comment)
|
Yup, looks OK to me. |
Thank you 😄 |
Motivation for this change
See: #43575
Move notice to README.md so that GitHub identifies the license and offers metadata for it, as proposed by @matthewbauer. Also, minor notice rewording.
cc @copumpkin @grahamc @pSub @samueldr