Skip to content

python.buildEnv: new argument makeWrapperArgs #48310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2018
Merged

python.buildEnv: new argument makeWrapperArgs #48310

merged 1 commit into from
Oct 13, 2018
+3 −1

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Oct 13, 2018

python.buildEnv would already wrap executables exporting PYTHONHOME.
With this change, it is possible to pass in additional arguments to the
underlying makeWrapper.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@FRidh
python.buildEnv: new argument makeWrapperArgs
00118ce 
`python.buildEnv` would already wrap executables exporting `PYTHONHOME`.
With this change, it is possible to pass in additional arguments to the
underlying `makeWrapper`.
@FRidh FRidh mentioned this pull request Oct 13, 2018
Closed
9 tasks
@FRidh FRidh changed the base branch from master to staging October 13, 2018 10:31
@FRidh FRidh merged commit 548ced6 into NixOS:staging Oct 13, 2018
@FRidh FRidh deleted the buildenv branch October 13, 2018 10:31
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ labels Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @Mic92 @GrahamcOfBorg