Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-sct: 20160529 -> 20180605 #48309

Merged
merged 1 commit into from Oct 13, 2018
Merged

go-sct: 20160529 -> 20180605 #48309

merged 1 commit into from Oct 13, 2018

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Oct 13, 2018
View reviewed changes
pkgs/tools/X11/go-sct/default.nix
maintainers = with maintainers; [ cstrahan ];
platforms = platforms.linux;
maintainers = with maintainers; [ rvolosatovs cstrahan ];
platforms = platforms.linux ++ platforms.windows;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do I test the windows build btw?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can install Nix to Cygwin. It didn't work very well the last time I tried, though :-(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Go packages have default meta.platforms, so it might make sense to remove it entirely:

nixpkgs/pkgs/development/go-modules/generic/default.nix

Line 224 in 7d238e6

platforms = go.meta.platforms or lib.platforms.all;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, I added this simply because the package itself has windows support. I do not have a windows machine to test this on.
@yegortimoshenko: this package does not support darwin.

@Mic92 Mic92 merged commit 91336f0 into NixOS:master Oct 13, 2018
@rvolosatovs rvolosatovs deleted the update/go-sct branch October 13, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@lukateras lukateras lukateras left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvolosatovs @Mic92 @lukateras @GrahamcOfBorg