Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-junit-report: init at 2018-06-14 (385fac0ce9a) #48318

Merged
merged 1 commit into from Oct 27, 2018
Merged

go-junit-report: init at 2018-06-14 (385fac0ce9a) #48318

merged 1 commit into from Oct 27, 2018

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Oct 13, 2018

Motivation for this change

tl;dr: pipe go test results into this and get enkins reports.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@cryptix
Copy link
Contributor Author

cryptix commented Oct 13, 2018 •
edited

GrahamcOfBorg build go-junit-report

yea, I guessed that won't work for me but I had to try.. 😅

@cryptix
Copy link
Contributor Author

cryptix commented Oct 15, 2018

squashed and rebased on master.

used this before nix and now over the weekend on a nix from jenkins witht his in its packages.

c0bw3b
c0bw3b reviewed Oct 27, 2018
View reviewed changes
pkgs/development/tools/go-junit-report/default.nix Outdated
# TODO: goDeps = ./deps.nix;

meta = with stdenv.lib; {
description = "Converts go test output to an xml report, suitable for applications that expect junit xml reports (e.g. Jenkins).";
Copy link
Contributor

@c0bw3b c0bw3b Oct 27, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the period at the end of the description please?
(as per nixpkgs manual)

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 27, 2018

@GrahamcOfBorg build go-junit-report

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go-junit-report

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/88glbppbvwj574jb8p3gkc7sqr9zrb2i-go-junit-report-unstable-2018-06-14-bin
shrinking /nix/store/88glbppbvwj574jb8p3gkc7sqr9zrb2i-go-junit-report-unstable-2018-06-14-bin/bin/go-junit-report
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/88glbppbvwj574jb8p3gkc7sqr9zrb2i-go-junit-report-unstable-2018-06-14-bin/bin
patching script interpreter paths in /nix/store/88glbppbvwj574jb8p3gkc7sqr9zrb2i-go-junit-report-unstable-2018-06-14-bin
checking for references to /build in /nix/store/88glbppbvwj574jb8p3gkc7sqr9zrb2i-go-junit-report-unstable-2018-06-14-bin...
cannot find section .dynamic
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
/nix/store/88glbppbvwj574jb8p3gkc7sqr9zrb2i-go-junit-report-unstable-2018-06-14-bin

@cryptix
Copy link
Contributor Author

cryptix commented Oct 27, 2018

Will update the description. While I'm at it: what about the version/date in the commit title? The package doesn't have a clear version published so I chose the date of the latest commit.

@cryptix
Copy link
Contributor Author

cryptix commented Oct 27, 2018

also removed the TODO: godeps.nix - this code is self-contained (expect stdlib).

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go-junit-report

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin
shrinking /nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin/bin/go-junit-report
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin/bin
patching script interpreter paths in /nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin
checking for references to /build in /nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin...
cannot find section .dynamic
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
/nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 27, 2018

Your commit message and package naming is good as it is.
You followed the manual recommendations for unstable packages where we fetch a given commit and not a stable revision (i.e. unstable in the name and date of the fetched commit as version)

@cryptix
Copy link
Contributor Author

cryptix commented Oct 27, 2018

perfect - just pushed the cleaned up commit and rebased it on master. thanks for the review!!

c0bw3b
c0bw3b approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nox-review ok

lrwxrwxrwx 1 xxxxx users 83 27 oct.  15:52 result-bin -> /nix/store/l91v09dgdlydq87avvkmvlip62g33281-go-junit-report-unstable-2018-06-14-bin

Thanks for the contribution

@c0bw3b c0bw3b merged commit 0e416d7 into NixOS:master Oct 27, 2018
@cryptix cryptix deleted the add/go-junit-report branch October 27, 2018 16:37
@cryptix cryptix restored the add/go-junit-report branch December 18, 2018 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptix @c0bw3b @GrahamcOfBorg