Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonic-pi: 3.0.1 -> 3.1.0 #48314

Merged
merged 1 commit into from Oct 16, 2018
Merged

sonic-pi: 3.0.1 -> 3.1.0 #48314

merged 1 commit into from Oct 16, 2018

Conversation

c0deaddict
Copy link
Member

Motivation for this change

There is a new version of sonic-pi available. The old version didn't work on my system, so I guess this change can be merged into the release branches as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Oct 13, 2018

@GrahamcOfBorg build sonic-pi

What do you mean by "didn't work on my system"?

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sonic-pi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: sonic-pi

Partial log (click to expand)

g++: error: unrecognized command line option '-msse'; did you mean '-fdse'?
make[2]: *** [external_libraries/CMakeFiles/boost_program_options.dir/build.make:180: external_libraries/CMakeFiles/boost_program_options.dir/boost/libs/program_options/src/variables_map.cpp.o] Error 1
g++: error: unrecognized command line option '-mfpmath=sse'
g++: error: unrecognized command line option '-msse2'
make[2]: *** [external_libraries/CMakeFiles/boost_program_options.dir/build.make:193: external_libraries/CMakeFiles/boost_program_options.dir/boost/libs/program_options/src/winmain.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1058: external_libraries/CMakeFiles/boost_program_options.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/vqgydq67da9wvwy7hnblv6crlv8478y8-supercollider-3.9.3.drv' failed with exit code 2
cannot build derivation '/nix/store/77fj6p7sdmz11b1qm78dy410sm1p0pg5-sonic-pi-3.1.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/77fj6p7sdmz11b1qm78dy410sm1p0pg5-sonic-pi-3.1.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sonic-pi

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
postPatchMkspecs
/nix/store/1kmypyd62n8842ywndj6k9z823gdnjmg-sonic-pi-3.1.0

@c0deaddict
Copy link
Member Author

@GrahamcOfBorg build sonic-pi

What do you mean by "didn't work on my system"?

I get this error message:

sonic-pi: include/boost/interprocess/segment_manager.hpp:861: void* boost::interprocess::segment_manager<CharType, MemoryAlgorithm, IndexType>::priv_generic_find(const CharT*, IndexType<boost::interprocess::ipcdetail::index_config<CharT, MemoryAlgorithm> >&, boost::interprocess::ipcdetail::in_place_interface&, boost::interprocess::segment_manager<CharType, MemoryAlgorithm, IndexType>::size_type&, boost::interprocess::ipcdetail::true_, bool) [with CharT = char; CharType = char; MemoryAlgorithm = boost::interprocess::rbtree_best_fit<boost::interprocess::mutex_family>; IndexType = boost::interprocess::iset_index; boost::interprocess::segment_manager<CharType, MemoryAlgorithm, IndexType>::size_type = long unsigned int; boost::interprocess::ipcdetail::true_ = boost::interprocess::ipcdetail::bool_<true>]: Assertion `(ctrl_data->m_value_bytes % table.size) == 0' failed.
/nix/store/fmna3rgrwwcdg6bpwgmi1y0ky1y158p9-sonic-pi-3.0.1/bin/.sonic-pi-wrapped: line 20:  2633 Aborted                 $DIR/../app/gui/qt/sonic-pi

Doesn't happen with 3.1.0

@timokau
Copy link
Member

timokau commented Oct 13, 2018

Alright. ofBorg reports a failure on aarch64. Apparently this didn't work before either because of a dependency failure, so its not necessary to fix it. But you should correct the platforms list of supercollider to platforms = [ "x686-linux" "x86_64-linux" ], since it doesn't work on aarch64 and never has. Then ofBorg should be happy too.

@timokau timokau added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 13, 2018
@c0deaddict
Copy link
Member Author

@timokau I've updated the commit with the changes you requested.

@timokau
Copy link
Member

timokau commented Oct 16, 2018

@GrahamcOfBorg build sonic-pi

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: sonic-pi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: sonic-pi

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sonic-pi

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
postPatchMkspecs
/nix/store/1kmypyd62n8842ywndj6k9z823gdnjmg-sonic-pi-3.1.0

timokau
timokau approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@timokau timokau merged commit 192dde6 into NixOS:master Oct 16, 2018
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0deaddict @timokau @GrahamcOfBorg @samueldr