Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: add jedi-vim #49592

Merged
merged 2 commits into from Nov 4, 2018
Merged

vimPlugins: add jedi-vim #49592

merged 2 commits into from Nov 4, 2018

Conversation

schmittlauch
Copy link
Member

This is the master branch equivalent of #49589, as the vimPlugins structure differs between master and release right now.

running the updated.py as described in the default.nix also updated
other vim plugins. If that's not wanted, I can reduce this changeset to
the jedi-vim related changes only.

As this is a python3 plugin it'd be nice to check for python3 support in
the used vim, but apparently nobody else does this.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@schmittlauch schmittlauch changed the title vim-plugins: add jedi-vim vimPlugins: add jedi-vim Nov 2, 2018
@schmittlauch
Copy link
Member Author

ping @jagajaga

andir
andir requested changes Nov 4, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I'd like to see here is that the bump of the other plugins in a commit separated from the addition of jedi-vim.

@schmittlauch
Copy link
Member Author

But the version bumps can still be included, just separated to another commit?

@andir
Copy link
Member

andir commented Nov 4, 2018

Yes, They will either happen now or someone will do them later... I do not see a test framework to verify that they actually work..

@andir
Copy link
Member

andir commented Nov 4, 2018

Besides that it works fine for me and I'd merge it once the commit is split :-)

@schmittlauch
Copy link
Member Author

@andir splitting is done.

andir
andir requested changes Nov 4, 2018
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just some nitpicks.

pkgs/misc/vim-plugins/overrides.nix Outdated Show resolved Hide resolved
pkgs/misc/vim-plugins/overrides.nix Show resolved Hide resolved
@schmittlauch
vim-plugins: add jedi-vim
da0db21 
As this is a python3 plugin it'd be nice to check for python3 support in
the used vim, but apparently nobody else does this.
@schmittlauch
vim-plugins: automatic version bumps
f6b41dd 
The recommended ./update.py script for adding new plugins also bumps the
version of already existing plugins.
@andir andir merged commit 8deff07 into NixOS:master Nov 4, 2018
@schmittlauch schmittlauch deleted the jedi-vim branch November 4, 2018 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schmittlauch @andir @GrahamcOfBorg