Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pmtools: remove and alias #49596

Merged
merged 1 commit into from Nov 1, 2018
Merged

pmtools: remove and alias #49596

merged 1 commit into from Nov 1, 2018

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 1, 2018 •
edited

Motivation for this change

These are the old tools that later became part of ACPICA.
It is obsolete and we already have newer acpica-tools in nixpkgs.
Alias to acpica-tools for out of tree backward-compat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@c0bw3b
pmtools: remove and alias
543c134 
These are the old tools that later became part of ACPICA.
It is obsolete and we already have newer acpica-tools.
Alias to acpica-tools for out of tree backward-compat
@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 1, 2018

Homepage and source tarballs are long gone too

@xeji
Copy link
Contributor

xeji commented Nov 1, 2018

Thank you for cleaning this up!

@xeji xeji merged commit db72b65 into NixOS:master Nov 1, 2018
@c0bw3b c0bw3b deleted the pkg/pmtools branch November 3, 2018 16:32
@c0bw3b c0bw3b added this to To do in Picking up garbage via automation May 10, 2019
@c0bw3b c0bw3b moved this from To do to Done in Picking up garbage May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@c0bw3b @xeji @GrahamcOfBorg