Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyjwt: fix tests to work with pytest >= 3.9.0 #49602

Merged
merged 1 commit into from Nov 24, 2018
Merged

pyjwt: fix tests to work with pytest >= 3.9.0 #49602

merged 1 commit into from Nov 24, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 1, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from FRidh as a code owner November 1, 2018 16:16
@cryptix
Copy link
Contributor

cryptix commented Nov 20, 2018

Just ran into this trying to build something that depends on pyjwt on master. Don't know much about python or pytest but this made it work.

@marsam
Copy link
Contributor

marsam commented Nov 22, 2018

upstream jpadilla/pyjwt#382

@FRidh FRidh merged commit 28cdb6e into NixOS:staging Nov 24, 2018
@glaubitz glaubitz mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @cryptix @marsam @FRidh @GrahamcOfBorg