-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/system: More Types of CPUs Added #49588
Conversation
I added some embedded platforms for the CPUs I added to the parse.nix file. These could be used as new platforms for the added CPUs.
@@ -112,11 +112,26 @@ rec { | |||
config = "aarch64-none-elf"; | |||
libc = "newlib"; | |||
}; | |||
|
|||
aarch64be-embedded = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ericson2314 do we have any requirements for systems added in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really! The only thing would be trying to keep the config
s unique.
Yes- the parse.nix changes are good but the changes to examples.nix might require some more discussion. Adding "alpha-embedded" definitely seems good because none of the other ones are alpha but I'm not so sure about the power/aarch64 "endian" cases. We don't need to cover every possible combination here - just the most common ones. I think both of those processors can switch between the two. |
They do support big-endian and little-endian. I thought adding support for both as some people might like to use little over big or vice versa. |
Looks fine for now! |
I have added more types of CPUs to try to support.
These could be useful for porting Nix packages to more platforms.