Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/system: More Types of CPUs Added #49588

Merged
merged 5 commits into from
Nov 12, 2018
Merged

Conversation

vincrusher
Copy link
Contributor

I have added more types of CPUs to try to support.

These could be useful for porting Nix packages to more platforms.

Co-Authored-By: vincrusher <vincentweisner@icloud.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 2, 2018
@vincrusher vincrusher changed the title More Types of CPUs Added. lib/system: More Types of CPUs Added Nov 5, 2018
I added some embedded platforms for the CPUs I added to the parse.nix file.
These could be used as new platforms for the added CPUs.
@@ -112,11 +112,26 @@ rec {
config = "aarch64-none-elf";
libc = "newlib";
};

aarch64be-embedded = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ericson2314 do we have any requirements for systems added in this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really! The only thing would be trying to keep the configs unique.

@matthewbauer
Copy link
Member

Yes- the parse.nix changes are good but the changes to examples.nix might require some more discussion. Adding "alpha-embedded" definitely seems good because none of the other ones are alpha but I'm not so sure about the power/aarch64 "endian" cases. We don't need to cover every possible combination here - just the most common ones. I think both of those processors can switch between the two.

@vincrusher
Copy link
Contributor Author

They do support big-endian and little-endian. I thought adding support for both as some people might like to use little over big or vice versa.

@matthewbauer matthewbauer merged commit d97e0ba into NixOS:master Nov 12, 2018
@matthewbauer
Copy link
Member

Looks fine for now!

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants