Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nlohmann_json: 3.3.0 -> 3.4.0 #49598

Merged
merged 1 commit into from Nov 1, 2018
Merged

nlohmann_json: 3.3.0 -> 3.4.0 #49598

merged 1 commit into from Nov 1, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 1, 2018

https://github.com/nlohmann/json/releases/tag/v3.4.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nlohmann_json

Partial log (click to expand)

-- Up-to-date: /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0/include/nlohmann
-- Up-to-date: /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0/include/nlohmann/json.hpp
-- Installing: /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonConfig.cmake
-- Installing: /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonConfigVersion.cmake
-- Installing: /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonTargets.cmake
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0/lib
patching script interpreter paths in /nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0
/nix/store/4r50bi52q99k65rp9nazr758hmkmbbl2-nlohmann_json-3.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nlohmann_json

Partial log (click to expand)

-- Installing: /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonConfig.cmake
-- Installing: /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonConfigVersion.cmake
-- Installing: /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonTargets.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0/lib
patching script interpreter paths in /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0
checking for references to /build in /nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0...
/nix/store/ssl10sc1vjkpj6m585pjgnvzwzch3877-nlohmann_json-3.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nlohmann_json

Partial log (click to expand)

-- Installing: /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonConfig.cmake
-- Installing: /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonConfigVersion.cmake
-- Installing: /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0/lib/cmake/nlohmann_json/nlohmann_jsonTargets.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0/lib
patching script interpreter paths in /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0
checking for references to /build in /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0...
/nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0

c0bw3b
c0bw3b approved these changes Nov 1, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did complete a nox-review of this on nixos-18.09 :

Result in /run/user/1234/nox-review-ngzgoozz
total 0
lrwxrwxrwx 1 zzzz users 59  1 nov.  21:01 result -> /nix/store/26vrlvs4n0imqx518cbzzh2d4hvzdayz-mtxclient-0.2.0
lrwxrwxrwx 1 zzzz users 67  1 nov.  21:01 result-2 -> /nix/store/qk4v8am3xrhwrahang9b0n6kzfp8l9rm-cpp-ipfs-api-2017-01-04
lrwxrwxrwx 1 zzzz users 61  1 nov.  21:01 result-3 -> /nix/store/a47zlc18nwmscg3gwp4ibvqqp66syc2z-toxvpn-2018-04-17
lrwxrwxrwx 1 zzzz users 63  1 nov.  21:01 result-4 -> /nix/store/6k3rkzi223d2bi8wl7hr7vjahqpy25ih-nlohmann_json-3.4.0

@c0bw3b c0bw3b merged commit 32382d2 into NixOS:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @c0bw3b